Support for symlinks in project references#1136
Conversation
|
Nice work @sheetalkamat! I can see there's a bunch of failing tests which you're no doubt looking into. Having had a quick look it seems that TypeScript <= 2.6 tests are failing. I've been wondering about dropping support for older versions of TypeScript; maybe making the minimum supported version TypeScript 3.6. It would speed up our CI considerably as we'd have a much smaller test matrix to run in Travis / AppVeyor. Users on older versions of TypeScript would still have older versions of ts-loader they could use. If it makes your life easier, then do feel free to consider doing that in this PR. TypeScript 2.6 was a long time ago! |
This is what resulted in using incorrect newLine in tests in SolutionBuilderHost
|
From the looks of it this is done @sheetalkamat? Thanks so much for your work! @andrewbranch would you be able to give this a review when you get a chance please? I've also upgraded the version in the |
|
Yep, I will do it this week if not today. 🚀 |
| @@ -0,0 +1 @@ | |||
| export const getMeaningOfLife2 = () => 45; No newline at end of file | |||
There was a problem hiding this comment.
That's a sick mind right there 😉
|
Thanks for all your work @sheetalkamat and thanks for the review @andrewbranch! |
Proved yarn workspaces, project references & ts-loader work together. Fixed in TypeStrong/ts-loader#1136
3 participants
Fixes #1114