Fix webpack deprecations (fix #1126)#1135
Fix webpack deprecations (fix #1126)#1135johnnyreilly merged 8 commits intoTypeStrong:masterfrom g-plane:fix-webpack-deprecations
Conversation
|
@sheetalkamat has a PR which drops support for older versions of TypeScript here: #1136 When that's merged we can take a look at your PR - it only seems to be failing on older versions of TypeScript. |
|
It seems that these are weird failures, and I'm not sure whether upgrading webpack will fix these or not, because webpack 4.37 (and newer versions) will check the current loader context is |
|
Very strange.... |
|
I've confirmed that upgrading webpack will solve the failures in CI, as those failures also can be reproduced on my local computer. Can I open another PR to upgrade webpack? If not, we may need to add some hacky code to check the loader context. |
|
Yeah sure - I'd like to decouple the upgrade of webpack from this change if that's okay. So upgrade webpack first and loop back to this next. |
|
PR for upgrading webpack is created: #1140 . |
|
I've marked this PR as ready for review, however I don't know how to address the problems at AppVeyor. |
|
AppVeyor has had a bad day - let's see if it fixes up now. |
|
Maybe we can migrate to GitHub Actions in the future. |
|
We're already using GitHub actions, but it doesn't cover the use case that AppVeyor provides; namely running CI on Windows. Maybe Azure pipelines has something to offer - I haven't taken a look in a while. I did start looking here though: |
johnnyreilly
left a comment
johnnyreilly
left a comment
There was a problem hiding this comment.
Good job! Do you want to increment the package.json and add an entry to the CHANGELOG.md?
|
I will. By the way, GitHub Actions supports Linux, Windows and macOS. |
g-plane
changed the title
|
Really? Did not know that! That said, I never managed to get comparison tests passing with GitHub actions. But that was the early days |
|
Maybe we can try it after this PR. |
|
I've updated |
|
Looks good! Let's wait for Travis to get happy then we can merge |
|
My feelings on AppVeyor right now |
|
All passed now. |
|
Shipping https://github.com/TypeStrong/ts-loader/releases/tag/v8.0.1 - thanks for your work! |
2 participants
This PR should remove some of webpack deprecation warnings.