Ensure that JSON files are included in build module resolution (#905)#1101
Merged
johnnyreilly merged 3 commits intoTypeStrong:masterfrom May 7, 2020
Merged
Conversation
Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig
Contributor
|
Thanks so much for doing this @berickson1! Do you think you’d be able to add a comparison test? |
Contributor
Author
|
@andrewbranch - Added a comparison-test for the positive case (& confirmed it didn't work before this change). Should I also add one for when resolveJsonModule is false? |
berickson1
force-pushed
the
berickson1/resolveJson
branch
from
43d97d6 to
4eb03b2
Compare
andrewbranch
approved these changes
May 7, 2020
Contributor
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
Looks good to me! Let me try to channel @johnnyreilly from across the Atlantic—
Great work, chap! 🌻 Could you update the package.json version and add an entry to the CHANGELOG.md too please?
andrewbranch
requested changes
May 7, 2020
Contributor
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
Maybe this is the reason for the failing tests on Travis?
johnnyreilly
approved these changes
May 7, 2020
Member
|
Thanks! |
berickson1
added a commit
to berickson1/ts-loader
that referenced
this pull request
May 22, 2020
…trong#905) (TypeStrong#1101) * Fix TypeStrong#905 Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig * Add test * PR Comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig
Fixes #905