refactor(dependency): update babel-code-frame to @babel/code-frame#409
refactor(dependency): update babel-code-frame to @babel/code-frame#409piotr-oles merged 2 commits intoTypeStrong:masterfrom
Conversation
|
I've set the dependency to ^7.5.5 because ^7.0.0 has issues with importing @babel/highlight. I can specify latest instead if you prefer though. |
|
We seem to have a failing test? |
Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency. Closes TypeStrong#408
|
We do... It's failing to clean up after the tests by the look of it. Each time I run these actions it seems to fail on a different OS using webpack 5, node 8. Can see if it does the same this time, but I'm wondering if this is just an issue with webpack alpha finishing when we expect. Is there a good way to try these tests on latest master to see if they're still passing repeatably? |
|
So they're all passing now... all I've changed is the commit author. |
|
Flaky tests are the worst! @piotr-oles are you happy for us to merge? |
|
Looks good. I think we should update the semantic-release config to trigger patch release for |
|
I have created a new PR: #410 to update the semantic-release configuration. We can merge this PR later. |
|
🎉 This PR is included in version 4.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
In case you hadn't already noticed, it looks like refactors don't appear in the release notes even though they do trigger releases. The github release looks blank for 4.1.4. Release itself is working great for me though. :) |
|
🎉 This PR is included in version 5.0.0-alpha.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Update code-frame dependency from v6 to v7 so that we can drop the chalk v1 dependency.
Closes #408