Skip to content

Conversation

@park9140
Copy link
Contributor

@park9140 park9140 commented Mar 6, 2015

Removing node modules as it is bad practice to include this in a repository.

Moving compiled content to 'dist' directory for better separation while developing.

Including map files to make debugging simpler.

Update out of date libraries.

@park9140
Copy link
Contributor Author

park9140 commented Mar 6, 2015

@basarat, I think this makes it much easier to work on the code. I have a few things I need to add before I can use this in the office. After this I intend to attempt to rectify the 600+ ms startup time, and depricated api usage.

@basarat
Copy link
Member

basarat commented Mar 6, 2015

Glad I didn't do a push. I'll merge and then commit my stuff ❤️

basarat added a commit that referenced this pull request Mar 6, 2015
Clean up build process to separate compiled content from raw content
@basarat basarat merged commit 3a5a43c into master Mar 6, 2015
@basarat basarat deleted the clean-up-build-process branch March 6, 2015 07:12
@basarat
Copy link
Member

basarat commented Mar 6, 2015

Including map files to make debugging simpler.

did it really help? I didn't see atom picking it up when I tried : #123

@basarat
Copy link
Member

basarat commented Mar 6, 2015

Nope. Sourcemaps don't work :
image

It's because our JS gets wrapped by atom in (function (exports, require, module, __filename, __dirname) { and });

So sourcemaps are no longer valid :
image

I'd be more interested in adding TypeScript support directly into atom once I get a chance. Looking at the recent 6to5 support its not that hard to do.

@basarat
Copy link
Member

basarat commented Mar 6, 2015

@park9140 also, we are building with atomts instead of grunt : 6134350

grunt is now there just for backup (when things go bang during development). Also note const enum handling is broken in the 1.4 language service : 6134350#diff-4e626b81616e50c89d68cba32c8d4c51L34 so if the last build isn't from atomts then the output would mismatch and there will be conflicts 👍

@csnover
Copy link
Member

csnover commented Mar 6, 2015

@park9140 also, we are building with atomts instead of grunt : 6134350

Nobody will know if the documentation is not kept up to date :) https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#building

@basarat
Copy link
Member

basarat commented Mar 6, 2015

@csnover on it

basarat added a commit that referenced this pull request Mar 6, 2015
@basarat
Copy link
Member

basarat commented Mar 6, 2015

@park9140 if sourcemaps indeed don't work for you as well delete them from the repo, grunt file,tsconfig. Or give me the go ahead ❤️

@park9140
Copy link
Contributor Author

park9140 commented Mar 6, 2015

@basarat, will do, I popped my debugger up and thought I was seeing them, but I'll take another look, maybe I had some weird setting, I played with adding direct typescript support before and may have enabled something that made them work.

@basarat basarat mentioned this pull request Mar 9, 2015
2 tasks
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants