Skip to content

[TT-17154] Docs update#8214

Merged
MFCaballero merged 5 commits into
masterfrom
TT-17154-docs-update
May 15, 2026
Merged

[TT-17154] Docs update#8214
MFCaballero merged 5 commits into
masterfrom
TT-17154-docs-update

Conversation

@MFCaballero

@MFCaballero MFCaballero commented May 13, 2026

Copy link
Copy Markdown
Contributor

Description

Update docs as per comments in https://github.com/TykTechnologies/tyk-docs/pull/2018/changes#r3234925620

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Ticket Details

TT-17154
Status In Code Review
Summary Gateway API + config 5.13.0

Generated at: 2026-05-15 14:28:21

@probelabs

probelabs Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

This pull request updates inline documentation and OpenAPI specifications to improve clarity and consistency based on feedback from the documentation team.

Files Changed Analysis

  • apidef/oas/error_overrides.go: The comment for the ErrorOverrides struct has been rephrased for better clarity.
  • config/config.go: Comments for TLS MinVersion and MaxVersion have been updated to link to the relevant documentation. The comment for AllowUnsafePolicyIds is now more descriptive, explaining which characters are considered standard and the risks of allowing others.
  • swagger.yml: Descriptions related to MCP Proxies now consistently use the term "Tyk Vendor Extension (x-tyk-api-gateway)". Additionally, descriptions for post_expiry_action and post_expiry_grace_period have been corrected to specify they apply to a "Session" in Redis, not a generic "key".

Architecture & Impact Assessment

  • What this PR accomplishes: This PR standardizes terminology and enhances descriptions in the codebase and API specification. It improves the developer and operator experience by making configuration options and API behaviors easier to understand. There are no functional changes.
  • Key technical changes introduced: The changes are purely cosmetic, involving updates to comments in Go files and descriptions in the swagger.yml OpenAPI specification.
  • Affected system components:
    • Gateway Configuration (config/config.go): Provides clearer guidance on TLS settings and the implications of using non-standard policy IDs.
    • API Definitions (apidef/oas/error_overrides.go): Improves the documentation for the error overrides feature in OAS-based APIs.
    • Management API Documentation (swagger.yml): Increases the accuracy of the generated API documentation, particularly for MCP and session-related fields.

Scope Discovery & Context Expansion

The scope of this PR is strictly limited to documentation within the codebase. The changes are a direct response to feedback on an external documentation repository (tyk-docs), indicating an effort to maintain consistency between internal and external documentation. As there are no changes to application logic, the impact is confined to improving developer and operator understanding. No further code exploration is necessary.

Metadata
  • Review Effort: 1 / 5
  • Primary Label: documentation

Powered by Visor from Probelabs

Last updated: 2026-05-15T14:29:14.731Z | Triggered by: pr_updated | Commit: f17666b

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs

probelabs Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

\n\n

✅ Performance Check Passed

No performance issues found – changes LGTM.

\n\n

✅ Quality Check Passed

No quality issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-05-15T14:29:02.394Z | Triggered by: pr_updated | Commit: f17666b

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Swagger Changes




  
  
  
  
  
  
  
  
  
     _        __  __
   _| |_   _ / _|/ _|  between swagger-prev.yml
  ± value change
  ± value change
  ± value change
  ± value change
  ± value change
  ± value change in multiline text (one insert, one deletion)
  ± value change in multiline text (one insert, one deletion)
 / _' | | | | |_| |_       and swagger-current.yml
 \__,_|\__, |_| |_|   returned seven differences
components.schemas.Policy.properties.post_expiry_action.description
components.schemas.Policy.properties.post_expiry_grace_period.description
components.schemas.SessionState.properties.post_expiry_action.description
components.schemas.SessionState.properties.post_expiry_grace_period.description
paths./tyk/mcps.get.description
paths./tyk/mcps.post.description
tags.MCP Proxies.description
| (_| | |_| |  _|  _|

@andyo-tyk andyo-tyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I don't know if this covers all the comments in the post-processed docs, but what's here is good. Thanks

@MFCaballero
MFCaballero enabled auto-merge (squash) May 15, 2026 08:02
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MFCaballero
MFCaballero merged commit a1c3b37 into master May 15, 2026
57 of 58 checks passed
@MFCaballero
MFCaballero deleted the TT-17154-docs-update branch May 15, 2026 15:48
@MFCaballero

Copy link
Copy Markdown
Contributor Author

/release to release-5.13.0

@probelabs

probelabs Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

✅ Cherry-pick successful. A PR was created: #8235

MFCaballero added a commit that referenced this pull request May 18, 2026
[TT-17154] Docs update (#8214)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Update docs as per comments in

https://github.com/TykTechnologies/tyk-docs/pull/2018/changes#r3234925620

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17154" title="TT-17154"
target="_blank">TT-17154</a>
</summary>

|         |    |
|---------|----|
| Status  | In Code Review |
| Summary | Gateway API + config 5.13.0 |

Generated at: 2026-05-15 08:01:55

</details>

<!---TykTechnologies/jira-linter ends here-->

[TT-17154]:
https://tyktech.atlassian.net/browse/TT-17154?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: Florencia Caballero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants