Skip to content

[TT-17190] Upgrade apache/thrift to 0.23.0#8194

Merged
MFCaballero merged 1 commit into
masterfrom
TT-17190
May 11, 2026
Merged

[TT-17190] Upgrade apache/thrift to 0.23.0#8194
MFCaballero merged 1 commit into
masterfrom
TT-17190

Conversation

@MFCaballero

@MFCaballero MFCaballero commented May 11, 2026

Copy link
Copy Markdown
Contributor

Description

Fix CVE-160: CVE-2026-41602 -> Requires Apache Thrift 0.23.0

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Ticket Details

TT-17190
Status In Dev
Summary Additional CVE fixes (Gateway & Dashboard)

Generated at: 2026-05-11 15:48:19

@probelabs

probelabs Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

This pull request upgrades the indirect dependency github.com/apache/thrift from version v0.22.0 to v0.23.0.

Files Changed Analysis

The changes are confined to go.mod and go.sum, reflecting the version bump of the apache/thrift package. This is a routine dependency update.

  • go.mod: Updated the version constraint for github.com/apache/thrift.
  • go.sum: Updated the checksums to match the new version of the dependency.

Architecture & Impact Assessment

  • What this PR accomplishes: The PR updates a single transitive dependency, likely to incorporate the latest security patches, bug fixes, or improvements from the Apache Thrift library.

  • Key technical changes introduced: The only change is the modification of the version number for github.com/apache/thrift in the go.mod file.

  • Affected system components: The apache/thrift library is not used directly by the Tyk Gateway. It is an indirect dependency pulled in by the jaeger-client-go package. Therefore, the only system component affected is the Jaeger distributed tracing integration. The Jaeger client uses the Thrift protocol to communicate trace data to the Jaeger agent or collector. The impact of this change is limited to the functionality of exporting traces to a Jaeger backend.

graph TD
    subgraph Tyk Gateway
        A[Trace Package] --> B[jaeger-client-go]
    end
    B -- Uses --> D[apache/thrift]
    B -- Sends Traces via Thrift Protocol --> C[Jaeger Agent/Collector]
Loading

Scope Discovery & Context Expansion

The scope of this change is very narrow and isolated. The primary impact is on the dependency tree related to the Jaeger tracing exporter. While the code change itself is minimal, dependency updates can carry unforeseen risks. Any potential issues would likely manifest as a failure to send traces to Jaeger, which could be verified through integration testing with a Jaeger backend enabled.

Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-05-11T15:47:08.257Z | Triggered by: pr_opened | Commit: 6a01e99

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs

probelabs Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

\n\n

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

\n\n

✅ Performance Check Passed

No performance issues found – changes LGTM.

✅ Quality Check Passed

No quality issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-05-11T15:46:57.647Z | Triggered by: pr_opened | Commit: 6a01e99

💡 TIP: You can chat with Visor using /visor ask <your question>

@MFCaballero MFCaballero added the deps-reviewed Dependency changes reviewed and approved for CI execution label May 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MFCaballero
MFCaballero merged commit 2648662 into master May 11, 2026
49 of 76 checks passed
@MFCaballero
MFCaballero deleted the TT-17190 branch May 11, 2026 17:23
@MFCaballero

Copy link
Copy Markdown
Contributor Author

/release to release-5.8

@probelabs

probelabs Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

⚠️ Cherry-pick encountered conflicts. A draft PR was created: #8195

@MFCaballero

Copy link
Copy Markdown
Contributor Author

/release to release-5.13

@MFCaballero

Copy link
Copy Markdown
Contributor Author

/release to release-5.13.0

@probelabs

probelabs Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

✅ Cherry-pick successful. A PR was created: #8196

@probelabs

probelabs Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

✅ Cherry-pick successful. A PR was created: #8197

probelabs Bot pushed a commit that referenced this pull request May 11, 2026
<!-- Provide a general summary of your changes in the Title above -->

## Description
Fix CVE-160: CVE-2026-41602 -> Requires Apache Thrift 0.23.0

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17190" title="TT-17190"
target="_blank">TT-17190</a>
</summary>

|         |    |
|---------|----|
| Status  | In Dev |
| Summary | Additional CVE fixes (Gateway & Dashboard) |

Generated at: 2026-05-11 15:48:19

</details>

<!---TykTechnologies/jira-linter ends here-->

(cherry picked from commit 2648662)

# Conflicts:
#	go.mod
#	go.sum
MFCaballero added a commit that referenced this pull request May 11, 2026
…to 0.23.0 (#8194) (#8196)

[TT-17190] Upgrade apache/thrift to 0.23.0 (#8194)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Fix CVE-160: CVE-2026-41602 -> Requires Apache Thrift 0.23.0

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why





<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17190" title="TT-17190"
target="_blank">TT-17190</a>
</summary>

|         |    |
|---------|----|
| Status  | In Code Review |
| Summary | Additional CVE fixes (Gateway & Dashboard) |

Generated at: 2026-05-11 18:37:00

</details>

<!---TykTechnologies/jira-linter ends here-->




[TT-17190]:
https://tyktech.atlassian.net/browse/TT-17190?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: Florencia Caballero <[email protected]>
MFCaballero added a commit that referenced this pull request May 15, 2026
…t to 0.23.0 (#8194) (#8197)

[TT-17190] Upgrade apache/thrift to 0.23.0 (#8194)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Fix CVE-160: CVE-2026-41602 -> Requires Apache Thrift 0.23.0

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why









<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-17190" title="TT-17190"
target="_blank">TT-17190</a>
</summary>

|         |    |
|---------|----|
| Status  | Merge |
| Summary | Additional CVE fixes (Gateway & Dashboard) |

Generated at: 2026-05-15 09:24:16

</details>

<!---TykTechnologies/jira-linter ends here-->








[TT-17190]:
https://tyktech.atlassian.net/browse/TT-17190?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: Florencia Caballero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps-reviewed Dependency changes reviewed and approved for CI execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants