[TT-11739] Re-add gateway.RateLimitExceeded (Dashboard coupling)#6318
Merged
titpetric merged 1 commit intoMay 30, 2024
Merged
Conversation
titpetric
changed the title
Contributor
|
PR Description updated to latest commit (20c780b) |
Contributor
PR Review 🔍
Code feedback: |
Contributor
|
API Changes --- prev.txt 2024-05-30 18:48:14.692810803 +0000
+++ current.txt 2024-05-30 18:48:11.320767590 +0000
@@ -7101,6 +7101,8 @@
const (
// EventQuotaExceeded is an alias maintained for backwards compatibility.
EventQuotaExceeded = event.QuotaExceeded
+ // RateLimitExceeded is an alias maintained for backwards compatibility.
+ RateLimitExceeded = event.RateLimitExceeded
// EventAuthFailure is an alias maintained for backwards compatibility.
EventAuthFailure = event.AuthFailure
// EventKeyExpired is an alias maintained for backwards compatibility. |
Contributor
PR Code Suggestions ✨
|
titpetric
enabled auto-merge (squash)
May 30, 2024 18:48
lghiur
approved these changes
May 30, 2024
|
nerdydread
pushed a commit
that referenced
this pull request
Sep 6, 2024
### **PR Type**
Bug fix
___
### **Description**
- Added the alias `RateLimitExceeded` in `gateway/event_system.go` to
maintain backwards compatibility.
___
### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug fix
</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>event_system.go</strong><dd><code>Add alias
`RateLimitExceeded` for backwards compatibility</code></dd></summary>
<hr>
gateway/event_system.go
- Added alias `RateLimitExceeded` for backwards compatibility.
</details>
</td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6318/files#diff-d56e22d4f1b8d2e91bb643d30e678a3819691a18bfae8506b10e0af8dc279a0e">+2/-0</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
___
> 💡 **PR-Agent usage**:
>Comment `/help` on the PR to get a list of all available PR-Agent tools
and their descriptions
Co-authored-by: Tit Petric <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix
Description
RateLimitExceededingateway/event_system.goto maintain backwards compatibility.Changes walkthrough 📝
event_system.go
Add alias `RateLimitExceeded` for backwards compatibilitygateway/event_system.go
RateLimitExceededfor backwards compatibility.