Skip to content

[TT-12114]update goerr113 with err113#6268

Merged
jeffy-mathew merged 1 commit into
masterfrom
fix/TT-12114/replace-goerr113
May 13, 2024
Merged

[TT-12114]update goerr113 with err113#6268
jeffy-mathew merged 1 commit into
masterfrom
fix/TT-12114/replace-goerr113

Conversation

@jeffy-mathew

@jeffy-mathew jeffy-mathew commented May 13, 2024

Copy link
Copy Markdown
Contributor

User description

Description

replace deprecated goerr113 linter with err113

Related Issue

Jira: https://tyktech.atlassian.net/browse/TT-12114

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

enhancement, configuration changes


Description

  • Replaced the deprecated linter goerr113 with the updated err113 in the .golangci.yml configuration file.

Changes walkthrough 📝

Relevant files
Configuration changes
.golangci.yml
Replace deprecated linter in golangci configuration           

.golangci.yml

  • Replaced the deprecated linter goerr113 with err113.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@github-actions

Copy link
Copy Markdown
Contributor

PR Description updated to latest commit (1498fe8)

@github-actions

Copy link
Copy Markdown
Contributor

PR Review 🔍

⏱️ Estimated effort to review [1-5]

1, because the PR involves a simple configuration change in the .golangci.yml file, replacing one linter with another. This is a straightforward update with minimal complexity.

🧪 Relevant tests

No

⚡ Possible issues

No

🔒 Security concerns

No

Code feedback:

@github-actions

Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
Verify the correctness of the linter name replacement to avoid potential configuration errors

It appears that the linter 'goerr113' has been replaced with 'err113'. Ensure that
'err113' is the correct and updated linter name as intended. If 'goerr113' was a typo or
an outdated linter, this change is correct. However, if 'goerr113' and 'err113' are
different linters, verify that this replacement won't omit necessary checks or introduce
unexpected behaviors.

.golangci.yml [75]

-- err113
+- correct_linter_name
 
Suggestion importance[1-10]: 7

Why: The suggestion correctly identifies the change from 'goerr113' to 'err113' and advises verification to ensure it's the correct and updated linter name. This is important to maintain the intended functionality of the linter configuration.

7

@github-actions

Copy link
Copy Markdown
Contributor

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@jeffy-mathew
jeffy-mathew enabled auto-merge (squash) May 13, 2024 08:22
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeffy-mathew
jeffy-mathew merged commit 4f5f37d into master May 13, 2024
@jeffy-mathew
jeffy-mathew deleted the fix/TT-12114/replace-goerr113 branch May 13, 2024 13:22
nerdydread pushed a commit that referenced this pull request Sep 6, 2024
### **User description**
<!-- Provide a general summary of your changes in the Title above -->

## Description

replace deprecated `goerr113` linter with `err113`
## Related Issue
Jira: https://tyktech.atlassian.net/browse/TT-12114
## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


___

### **PR Type**
enhancement, configuration changes


___

### **Description**
- Replaced the deprecated linter `goerr113` with the updated `err113` in
the `.golangci.yml` configuration file.


___



### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Configuration changes
</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>.golangci.yml</strong><dd><code>Replace deprecated
linter in golangci configuration</code>&nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; </dd></summary>
<hr>

.golangci.yml
- Replaced the deprecated linter `goerr113` with `err113`.



</details>
    

  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6268/files#diff-6179837f7df53a6f05c522b6b7bb566d484d5465d9894fb04910dd08bb40dcc9">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>
</tr>                    
</table></td></tr></tr></tbody></table>

___

> 💡 **PR-Agent usage**:
>Comment `/help` on the PR to get a list of all available PR-Agent tools
and their descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants