[TT-11925] Reset plugin compiler build env to match gateway build env by titpetric · Pull Request #6234 · TykTechnologies/tyk

titpetric · 2024-04-19T10:52:02Z

User description

Gateway uses bullseye for the build, while plugin compiler used bookworm. This resets the plugin compiler to use bullseye, as the build environment has to match for plugin compatibility.

This also removes unnecessary packages.

https://tyktech.atlassian.net/browse/TT-11925
https://tyktech.atlassian.net/browse/TT-11855

Type

bug_fix

Description

The build environment for the plugin compiler has been updated to 1.21-bullseye to match the gateway build environment, ensuring compatibility.

Changes walkthrough

Relevant files

Configuration changes

plugin-compiler-build.yml `Update Plugin Compiler Build Environment to Match Gateway` .github/workflows/plugin-compiler-build.yml Updated the build environment for the plugin compiler to use `1.21-bullseye` instead of `1.21-bookworm`.	+1/-1

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

github-actions · 2024-04-19T10:52:43Z

PR Description updated to latest commit (f2d5e94)

github-actions · 2024-04-19T10:52:46Z

API Changes

no api changes detected

github-actions · 2024-04-19T10:52:52Z

PR Review

⏱️ Estimated effort to review [1-5]	1, because the PR involves a simple change of a single environment variable in a YAML configuration file. The change is straightforward and does not involve complex logic or multiple files.
🧪 Relevant tests	No
🔍 Possible issues	No
🔒 Security concerns	No

Code feedback:

✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

github-actions · 2024-04-19T10:53:02Z

PR Code Suggestions

Category	Suggestions
Best practice	Ensure the GOLANG_CROSS version is consistent and well-supported. Ensure that the GOLANG_CROSS version is consistent with the versions used in other related workflows or environments to avoid potential compatibility issues. If "1.21-bullseye" is not a standard or widely supported version, consider using a version that is better supported or recommended by the community. .github/workflows/plugin-compiler-build.yml [14] -GOLANG_CROSS: 1.21-bullseye +GOLANG_CROSS: <recommended-version>

✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

github-actions · 2024-04-19T16:01:33Z

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

sonarqubecloud · 2024-04-19T16:19:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

titpetric · 2024-04-19T16:35:27Z

/release to release-5.3.1

tykbot · 2024-04-19T16:35:56Z

Working on it! Note that it can take a few minutes.

…#6234) ## **User description** Gateway uses bullseye for the build, while plugin compiler used bookworm. This resets the plugin compiler to use bullseye, as the build environment has to match for plugin compatibility. This also removes unnecessary packages. https://tyktech.atlassian.net/browse/TT-11925 https://tyktech.atlassian.net/browse/TT-11855 ___ ## **Type** bug_fix ___ ## **Description** - The build environment for the plugin compiler has been updated to `1.21-bullseye` to match the gateway build environment, ensuring compatibility. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes </strong></td><td><table> <tr> <td> <details> <summary><strong>plugin-compiler-build.yml</strong><dd><code>Update Plugin Compiler Build Environment to Match Gateway</code></dd></summary> <hr> .github/workflows/plugin-compiler-build.yml <li>Updated the build environment for the plugin compiler to use <br><code>1.21-bullseye</code> instead of <code>1.21-bookworm</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6234/files#diff-f3a95a900eb0ac23af6314e9cdea29fa16af0a9bcb61793a83a32ff13d4c4e79">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 475e41e)

tykbot · 2024-04-19T16:36:21Z

@titpetric Succesfully merged PR

titpetric · 2024-04-19T16:38:45Z

/release to release-5.3

tykbot · 2024-04-19T16:40:06Z

Working on it! Note that it can take a few minutes.

…#6234) ## **User description** Gateway uses bullseye for the build, while plugin compiler used bookworm. This resets the plugin compiler to use bullseye, as the build environment has to match for plugin compatibility. This also removes unnecessary packages. https://tyktech.atlassian.net/browse/TT-11925 https://tyktech.atlassian.net/browse/TT-11855 ___ ## **Type** bug_fix ___ ## **Description** - The build environment for the plugin compiler has been updated to `1.21-bullseye` to match the gateway build environment, ensuring compatibility. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes </strong></td><td><table> <tr> <td> <details> <summary><strong>plugin-compiler-build.yml</strong><dd><code>Update Plugin Compiler Build Environment to Match Gateway</code></dd></summary> <hr> .github/workflows/plugin-compiler-build.yml <li>Updated the build environment for the plugin compiler to use <br><code>1.21-bullseye</code> instead of <code>1.21-bookworm</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6234/files#diff-f3a95a900eb0ac23af6314e9cdea29fa16af0a9bcb61793a83a32ff13d4c4e79">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 475e41e)

tykbot · 2024-04-19T16:40:25Z

@titpetric Succesfully merged PR

… match gateway build env (#6234) [TT-11925] Reset plugin compiler build env to match gateway build env (#6234) ## **User description** Gateway uses bullseye for the build, while plugin compiler used bookworm. This resets the plugin compiler to use bullseye, as the build environment has to match for plugin compatibility. This also removes unnecessary packages. https://tyktech.atlassian.net/browse/TT-11925 https://tyktech.atlassian.net/browse/TT-11855 ___ ## **Type** bug_fix ___ ## **Description** - The build environment for the plugin compiler has been updated to `1.21-bullseye` to match the gateway build environment, ensuring compatibility. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes </strong></td><td><table> <tr> <td> <details> <summary><strong>plugin-compiler-build.yml</strong><dd><code>Update Plugin Compiler Build Environment to Match Gateway</code></dd></summary> <hr> .github/workflows/plugin-compiler-build.yml <li>Updated the build environment for the plugin compiler to use <br><code>1.21-bullseye</code> instead of <code>1.21-bookworm</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6234/files#diff-f3a95a900eb0ac23af6314e9cdea29fa16af0a9bcb61793a83a32ff13d4c4e79">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --------- Co-authored-by: Tit Petric <[email protected]>

…to match gateway build env (#6234) [TT-11925] Reset plugin compiler build env to match gateway build env (#6234) ## **User description** Gateway uses bullseye for the build, while plugin compiler used bookworm. This resets the plugin compiler to use bullseye, as the build environment has to match for plugin compatibility. This also removes unnecessary packages. https://tyktech.atlassian.net/browse/TT-11925 https://tyktech.atlassian.net/browse/TT-11855 ___ ## **Type** bug_fix ___ ## **Description** - The build environment for the plugin compiler has been updated to `1.21-bullseye` to match the gateway build environment, ensuring compatibility. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes </strong></td><td><table> <tr> <td> <details> <summary><strong>plugin-compiler-build.yml</strong><dd><code>Update Plugin Compiler Build Environment to Match Gateway</code></dd></summary> <hr> .github/workflows/plugin-compiler-build.yml <li>Updated the build environment for the plugin compiler to use <br><code>1.21-bullseye</code> instead of <code>1.21-bookworm</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6234/files#diff-f3a95a900eb0ac23af6314e9cdea29fa16af0a9bcb61793a83a32ff13d4c4e79">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions --------- Co-authored-by: Tit Petric <[email protected]>

Reset plugin compiler build env to match gateway build env

f2d5e94

github-actions Bot added the bug_fix label Apr 19, 2024

github-actions Bot added the Review effort [1-5]: 1 label Apr 19, 2024

titpetric requested review from asutosh and jeffy-mathew April 19, 2024 10:55

asutosh approved these changes Apr 19, 2024

View reviewed changes

jeffy-mathew approved these changes Apr 19, 2024

View reviewed changes

titpetric changed the title ~~Reset plugin compiler build env to match gateway build env~~ [TT-11925] Reset plugin compiler build env to match gateway build env Apr 19, 2024

plugin compiler: update dockerfile, update test taskfile

89adebc

titpetric requested a review from a team as a code owner April 19, 2024 15:53

titpetric enabled auto-merge (squash) April 19, 2024 15:59

titpetric merged commit 475e41e into master Apr 19, 2024

titpetric deleted the fix/plugin-compiler-build-env branch April 19, 2024 16:34

buger mentioned this pull request Apr 19, 2024

Merging to release-5.3.1: [TT-11925] Reset plugin compiler build env to match gateway build env (#6234) #6237

Merged

buger mentioned this pull request Apr 19, 2024

Merging to release-5.3: [TT-11925] Reset plugin compiler build env to match gateway build env (#6234) #6238

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TT-11925] Reset plugin compiler build env to match gateway build env#6234

[TT-11925] Reset plugin compiler build env to match gateway build env#6234
titpetric merged 2 commits into
masterfrom
fix/plugin-compiler-build-env

titpetric commented Apr 19, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

sonarqubecloud Bot commented Apr 19, 2024

Uh oh!

titpetric commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

titpetric commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

titpetric commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Type

Description

Changes walkthrough

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

Uh oh!

github-actions Bot commented Apr 19, 2024

PR Review

Uh oh!

github-actions Bot commented Apr 19, 2024

PR Code Suggestions

Uh oh!

github-actions Bot commented Apr 19, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

sonarqubecloud Bot commented Apr 19, 2024

Quality Gate passed

Uh oh!

titpetric commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

titpetric commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

tykbot Bot commented Apr 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

titpetric commented Apr 19, 2024 •

edited

Loading