TT-11485, fix for global rate limit disabled flag not working by andrei-tyk · Pull Request #6120 · TykTechnologies/tyk

andrei-tyk · 2024-03-07T15:41:46Z

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

I ensured that the documentation is up to date
I explained why this PR updates go.mod in detail with reasoning why it's required
I would like a code coverage CI quality gate exception and have explained why

Type

Bug fix

Description

Fixed an issue where the global rate limit disabled flag was not properly checked, causing the rate limiter to be incorrectly enabled.

Changes walkthrough

Relevant files

Bug fix

mw_api_rate_limit.go `Fix Global Rate Limit Disabled Flag Check` gateway/mw_api_rate_limit.go Added a condition to check `GlobalRateLimit.Disabled` flag in `EnabledForSpec` function.	+1/-1

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

github-actions · 2024-03-07T15:42:33Z

PR Description updated to latest commit (382153a)

github-actions · 2024-03-07T15:42:46Z

PR Review

⏱️ Estimated effort to review [1-5]	1, because the PR consists of a simple logic change in a single condition. The change is straightforward and does not seem to involve complex logic or dependencies.
🧪 Relevant tests	No
🔍 Possible issues	Possible Bug: If `k.Spec.GlobalRateLimit.Disabled` is true but `k.Spec.DisableRateLimit` and `k.Spec.GlobalRateLimit.Rate` are not, this change will disable rate limiting even if it's not intended. Ensure this behavior is consistent with the application's requirements.
🔒 Security concerns	No

Code feedback:

relevant file	gateway/mw_api_rate_limit.go
suggestion	Consider adding a unit test to verify that the rate limiter is correctly enabled or disabled based on the new condition. This will help prevent future regressions and ensure the logic works as intended. [important]
relevant line	if k.Spec.DisableRateLimit \|\| k.Spec.GlobalRateLimit.Rate == 0 \|\| k.Spec.GlobalRateLimit.Disabled {

✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: `[pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
How to enable\disable automation When you first install PR-Agent app, the default mode for the `review` tool is: `pr_commands = ["/review", ...]` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
Auto-labels The `review` tool can auto-generate two specific types of labels for a PR: a `possible security issue` label, that detects possible security issues (`enable_review_labels_security` flag) a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
Extra sub-tools The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more.
Auto-approve PRs By invoking: `/review auto_approve` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: `[pr_reviewer] enable_auto_approval = true` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: `[pr_reviewer] maximal_review_effort = 5`
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

github-actions · 2024-03-07T15:42:48Z

PR Code Suggestions

Category	Suggestions
Possible issue	Add a nil check for `GlobalRateLimit` to prevent potential nil pointer dereference. Consider checking for `k.Spec.GlobalRateLimit` being `nil` before accessing its properties to avoid potential nil pointer dereference. This is important because if `GlobalRateLimit` is not initialized, accessing `Rate` or `Disabled` will cause a runtime panic. gateway/mw_api_rate_limit.go [29] -if k.Spec.DisableRateLimit \|\| k.Spec.GlobalRateLimit.Rate == 0 \|\| k.Spec.GlobalRateLimit.Disabled { +if k.Spec.DisableRateLimit \|\| (k.Spec.GlobalRateLimit != nil && (k.Spec.GlobalRateLimit.Rate == 0 \|\| k.Spec.GlobalRateLimit.Disabled)) {

✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the improve tool is: `pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
Utilizing extra instructions Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: `[pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
A note on code suggestions quality While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool With large PRs, best quality will be obtained by using 'improve --extended' mode.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.

github-actions · 2024-03-07T15:47:40Z

API Changes

no api changes detected

buger · 2024-03-07T16:09:40Z

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/heads/master
Commit:
Triggered by: schedule (@alephnull)
Execution page

buger · 2024-03-07T16:09:43Z

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/heads/master
Commit:
Triggered by: schedule (@alephnull)
Execution page

github-actions · 2024-03-08T09:13:02Z

💥 CI tests failed 🙈

git-state

diff --git a/gateway/mw_api_rate_limit_test.go b/gateway/mw_api_rate_limit_test.go
index 0b47c01..7150f0d 100644
--- a/gateway/mw_api_rate_limit_test.go
+++ b/gateway/mw_api_rate_limit_test.go
@@ -1,13 +1,14 @@
 package gateway
 
 import (
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/justinas/alice"
 
 	"github.com/TykTechnologies/tyk/internal/uuid"

Please look at the run or in the Checks tab.

github-actions · 2024-03-08T09:13:03Z

💥 CI tests failed 🙈

git-state

diff --git a/gateway/mw_api_rate_limit_test.go b/gateway/mw_api_rate_limit_test.go
index 0b47c01..7150f0d 100644
--- a/gateway/mw_api_rate_limit_test.go
+++ b/gateway/mw_api_rate_limit_test.go
@@ -1,13 +1,14 @@
 package gateway
 
 import (
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"net/http/httptest"
 	"net/url"
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/justinas/alice"
 
 	"github.com/TykTechnologies/tyk/internal/uuid"

Please look at the run or in the Checks tab.

…limiter

…-api-rate-limiter' into TT-11485-not-possible-to-disable-api-rate-limiter

sonarqubecloud · 2024-03-08T09:53:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-03-08T10:02:16Z

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

buger · 2024-03-08T10:20:20Z

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/heads/master
Commit:
Triggered by: schedule (@alephnull)
Execution page

buger · 2024-03-08T10:27:51Z

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit:
Triggered by: schedule (@alephnull)
Execution page

buger · 2024-03-08T10:27:51Z

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 53886d0 TT-11485, fix for global rate limit disabled flag not working (#6120)

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing
functionality to change)
Refactoring or add test (improvements in base code or adds test
coverage to functionality)

Checklist

I ensured that the documentation is up to date
I explained why this PR updates go.mod in detail with reasoning
why it's required
I would like a code coverage CI quality gate exception and have
explained why

Type

Bug fix

Description

Fixed an issue where the global rate limit disabled flag was not
properly checked, causing the rate limiter to be incorrectly enabled.

Changes walkthrough

Relevant files

Bug fix

mw_api_rate_limit.go `Fix Global Rate Limit Disabled Flag Check` gateway/mw_api_rate_limit.go Added a condition to check `GlobalRateLimit.Disabled` flag in `EnabledForSpec` function.	+1/-1

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools
and their descriptions
Triggered by: push (@andrei-tyk)
Execution page

andrei-tyk · 2024-03-08T10:53:37Z

/release to release-5.3

andrei-tyk · 2024-03-08T10:53:47Z

/release to release-5.3.0

tykbot · 2024-03-08T10:53:53Z

Working on it! Note that it can take a few minutes.

tykbot · 2024-03-08T10:53:59Z

Working on it! Note that it can take a few minutes.

## **User description**  ## Description  ## Related Issue     ## Motivation and Context  ## How This Has Been Tested     ## Screenshots (if appropriate) ## Types of changes  - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist    - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ## **Type** Bug fix ___ ## **Description** - Fixed an issue where the global rate limit disabled flag was not properly checked, causing the rate limiter to be incorrectly enabled. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Fix Global Rate Limit Disabled Flag Check</code>                                </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added a condition to check <code>GlobalRateLimit.Disabled</code> flag in <br><code>EnabledForSpec</code> function.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6120/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions (cherry picked from commit 53886d0)

…flag not working (#6120) TT-11485, fix for global rate limit disabled flag not working (#6120) ## **User description**  ## Description  ## Related Issue     ## Motivation and Context  ## How This Has Been Tested     ## Screenshots (if appropriate) ## Types of changes  - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist    - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ## **Type** Bug fix ___ ## **Description** - Fixed an issue where the global rate limit disabled flag was not properly checked, causing the rate limiter to be incorrectly enabled. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Fix Global Rate Limit Disabled Flag Check</code>                                </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added a condition to check <code>GlobalRateLimit.Disabled</code> flag in <br><code>EnabledForSpec</code> function.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6120/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions

tykbot · 2024-03-08T10:54:15Z

@andrei-tyk Succesfully merged PR

## **User description**  ## Description  ## Related Issue     ## Motivation and Context  ## How This Has Been Tested     ## Screenshots (if appropriate) ## Types of changes  - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist    - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ## **Type** Bug fix ___ ## **Description** - Fixed an issue where the global rate limit disabled flag was not properly checked, causing the rate limiter to be incorrectly enabled. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Fix Global Rate Limit Disabled Flag Check</code>                                </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added a condition to check <code>GlobalRateLimit.Disabled</code> flag in <br><code>EnabledForSpec</code> function.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6120/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions (cherry picked from commit 53886d0)

tykbot · 2024-03-08T10:54:34Z

Still working...

tykbot · 2024-03-08T10:54:37Z

@andrei-tyk Seems like there is conflict and it require manual merge.

…d flag not working (#6120) (#6128) ## **User description** TT-11485, fix for global rate limit disabled flag not working (#6120) ## **User description**  ## Description  ## Related Issue     ## Motivation and Context  ## How This Has Been Tested     ## Screenshots (if appropriate) ## Types of changes  - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist    - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ## **Type** Bug fix ___ ## **Description** - Fixed an issue where the global rate limit disabled flag was not properly checked, causing the rate limiter to be incorrectly enabled. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Fix Global Rate Limit Disabled Flag Check</code>                                </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added a condition to check <code>GlobalRateLimit.Disabled</code> flag in <br><code>EnabledForSpec</code> function.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6120/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+1/-1</a>      </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions ___ ## **Type** Bug fix, Tests ___ ## **Description** - Added a missing condition to properly check if the global rate limit is disabled in the `EnabledForSpec` function. - Introduced a new test case to ensure the `EnabledForSpec` function respects the `GlobalRateLimit.Disabled` flag. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix </strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit.go</strong><dd><code>Fix Global Rate Limit Disabled Flag Check</code>                                </dd></summary> <hr> gateway/mw_api_rate_limit.go <li>Added a condition to check if <code>GlobalRateLimit.Disabled</code> is true in the <br><code>EnabledForSpec</code> function.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6128/files#diff-46326b04f936c839922e970db5c2924156cc797070948f3dc9c589d04661d6d2">+1/-1</a>      </td> </tr> </table></td></tr><tr><td><strong>Tests </strong></td><td><table> <tr> <td> <details> <summary><strong>mw_api_rate_limit_test.go</strong><dd><code>Add Test for Global Rate Limit Disabled Flag</code>                          </dd></summary> <hr> gateway/mw_api_rate_limit_test.go <li>Imported <code>apidef</code> and <code>assert</code> packages for testing.<br> <li> Added a new test <code>TestRateLimitForAPI_EnabledForSpec</code> to verify the <br>correct behavior of the <code>EnabledForSpec</code> function when the global rate <br>limit is disabled.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6128/files#diff-8485978214ae83eb8aeeda3519a1e90350a2a84067de47462f40f0938861dc45">+11/-0</a>    </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: andrei-tyk <[email protected]>

TT-11485, fix for global rate limit disabled flag not working

382153a

github-actions Bot added the Bug fix label Mar 7, 2024

github-actions Bot added the Review effort [1-5]: 1 label Mar 7, 2024

titpetric approved these changes Mar 8, 2024

View reviewed changes

TT-11485, unit test for EnabledForSpec

16a304e

andrei-tyk and others added 2 commits March 8, 2024 11:25

TT-11485, mkae lint

9ecb5f0

Merge branch 'master' into TT-11485-not-possible-to-disable-api-rate-…

4f7aba3

…limiter

andrei-tyk enabled auto-merge (squash) March 8, 2024 09:26

titpetric approved these changes Mar 8, 2024

View reviewed changes

andrei-tyk added 3 commits March 8, 2024 11:38

TT-11485, better unit testing

e3f3afa

Merge remote-tracking branch 'origin/TT-11485-not-possible-to-disable…

6541ed0

…-api-rate-limiter' into TT-11485-not-possible-to-disable-api-rate-limiter

TT-11485, cleanup

3fa3f16

andrei-tyk merged commit 53886d0 into master Mar 8, 2024

andrei-tyk deleted the TT-11485-not-possible-to-disable-api-rate-limiter branch March 8, 2024 10:04

buger mentioned this pull request Mar 8, 2024

Merging to release-5.3: TT-11485, fix for global rate limit disabled flag not working (#6120) #6127

Merged

7 tasks

buger mentioned this pull request Mar 8, 2024

Merging to release-5.3.0: TT-11485, fix for global rate limit disabled flag not working (#6120) #6128

Merged

7 tasks

Uh oh!

Conversation

andrei-tyk commented Mar 7, 2024 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Checklist

Type

Description

Changes walkthrough

Uh oh!

github-actions Bot commented Mar 7, 2024

Uh oh!

github-actions Bot commented Mar 7, 2024

PR Review

Uh oh!

github-actions Bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions

Uh oh!

github-actions Bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buger commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buger commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 8, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

github-actions Bot commented Mar 8, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

sonarqubecloud Bot commented Mar 8, 2024

Quality Gate passed

Uh oh!

github-actions Bot commented Mar 8, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

buger commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buger commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buger commented Mar 8, 2024

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Checklist

Type

Description

Changes walkthrough

Uh oh!

andrei-tyk commented Mar 8, 2024

Uh oh!

andrei-tyk commented Mar 8, 2024

Uh oh!

tykbot Bot commented Mar 8, 2024

Uh oh!

tykbot Bot commented Mar 8, 2024

Uh oh!

tykbot Bot commented Mar 8, 2024

Uh oh!

tykbot Bot commented Mar 8, 2024

Uh oh!

andrei-tyk commented Mar 7, 2024 •

edited by github-actions Bot

Loading

github-actions Bot commented Mar 7, 2024 •

edited

Loading

github-actions Bot commented Mar 7, 2024 •

edited

Loading

buger commented Mar 7, 2024 •

edited

Loading

buger commented Mar 7, 2024 •

edited

Loading

buger commented Mar 8, 2024 •

edited

Loading

buger commented Mar 8, 2024 •

edited

Loading