[TT-11452] remove unused migrate func#6117
Conversation
|
PR Description updated to latest commit (c528f55) |
PR Review
Code feedback:✨ Review tool usage guide:Overview: With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
|
API Changes --- prev.txt 2024-03-07 20:44:11.681427931 +0000
+++ current.txt 2024-03-07 20:44:08.853431719 +0000
@@ -3652,8 +3652,6 @@
func (p *PrePlugin) Fill(api apidef.APIDefinition)
Fill fills PrePlugin from supplied Tyk classic api definition.
-func (p *PrePlugin) Migrate() CustomPlugins
-
type Provider struct {
// Issuer contains a validation value for the issuer claim, usually a domain name e.g. `accounts.google.com` or similar.
Issuer string `bson:"issuer,omitempty" json:"issuer,omitempty"` |
PR Code SuggestionsNo code suggestions found for PR. |
|
API tests result - mongo44-sha256 env: success ✅ Descriptionremove unused migrate func Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
|
|
API tests result - postgres15-sha256 env: success ✅ Descriptionremove unused migrate func Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
|
|
ae9b56a to
e9aa589
Compare
|
|
API tests result - postgres15-murmur64 env: success ✅ Descriptionremove unused migrate func Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
|
|
API tests result - mongo44-murmur64 env: success ✅ Descriptionremove unused migrate func Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
|
|
/release to release-5.3 |
|
/release to release-5.3.0 |
|
Working on it! Note that it can take a few minutes. |
1 similar comment
|
Working on it! Note that it can take a few minutes. |
<!-- Provide a general summary of your changes in the Title above --> ## Description remove unused migrate func ## Related Issue https://tyktech.atlassian.net/browse/TT-11452 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why (cherry picked from commit 0497abf)
[TT-11452] remove unused migrate func (#6117) <!-- Provide a general summary of your changes in the Title above --> ## Description remove unused migrate func ## Related Issue https://tyktech.atlassian.net/browse/TT-11452 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why
|
@jeffy-mathew Succesfully merged PR |
<!-- Provide a general summary of your changes in the Title above --> ## Description remove unused migrate func ## Related Issue https://tyktech.atlassian.net/browse/TT-11452 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why (cherry picked from commit 0497abf)
|
Still working... |
[TT-11452] remove unused migrate func (#6117) <!-- Provide a general summary of your changes in the Title above --> ## Description remove unused migrate func ## Related Issue https://tyktech.atlassian.net/browse/TT-11452 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why
|
@jeffy-mathew Succesfully merged PR |
3 participants
User description
Description
remove unused migrate func
Related Issue
https://tyktech.atlassian.net/browse/TT-11452
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
Type
enhancement
Description
Migratemethod fromPrePluginstruct to clean up the codebase. This contributes to maintaining a cleaner and more maintainable codebase.Changes walkthrough
middleware.go
Remove Unused `Migrate` Function in `PrePlugin`apidef/oas/middleware.go
Migratefunction from thePrePluginstruct.