Skip to content

TT-11288 Revert logger mutex#6103

Merged
sredxny merged 1 commit into
masterfrom
TT-11288-fix/memory-leak-remove-logger-lock
Mar 6, 2024
Merged

TT-11288 Revert logger mutex#6103
sredxny merged 1 commit into
masterfrom
TT-11288-fix/memory-leak-remove-logger-lock

Conversation

@sredxny

@sredxny sredxny commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

User description

Description

Remove the mutex for the logger

Related Issue

TT-11288

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Type

bug_fix


Description

  • Removed the mutex lock from the logger in the BaseMiddleware struct to address potential performance issues and simplify the code.
  • Updated methods (Base(), Logger(), SetName(), and SetRequestLogger()) in BaseMiddleware to operate without mutex synchronization.

Changes walkthrough

Relevant files
Bug fix
middleware.go
Remove Logger Mutex in BaseMiddleware                                       

gateway/middleware.go

  • Removed mutex (sync.Mutex) for logger in BaseMiddleware struct.
  • Simplified Base(), Logger(), SetName(), and SetRequestLogger() methods
    by removing mutex locks and unlocks.
  • Ensured logger instance is directly manipulated without mutex
    synchronization.
  • +8/-32   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    PR Description updated to latest commit (a8f45d4)

    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    PR Review

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are straightforward and localized to a specific functionality (logging within the BaseMiddleware). The removal of mutex suggests a focus on performance improvement but requires careful consideration of concurrency implications.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Thread Safety: Removing the mutex (loggerMu) from BaseMiddleware could introduce race conditions if BaseMiddleware's logging functions are called concurrently from multiple goroutines.

    Logger State Consistency: Since the mutex lock is removed, concurrent modifications to the logger (e.g., SetName, SetRequestLogger) might lead to inconsistent logger states.

    🔒 Security concerns

    No

    Code feedback:
    relevant filegateway/middleware.go
    suggestion      

    Consider implementing a thread-safe singleton pattern for the logger instance in BaseMiddleware to ensure that concurrent access does not lead to race conditions or inconsistent states. This can be achieved by using atomic operations or reintroducing a locking mechanism that has minimal performance impact. [important]

    relevant linelogger *logrus.Entry

    relevant filegateway/middleware.go
    suggestion      

    Evaluate the performance impact of removing the mutex in high-concurrency scenarios. If the performance gain is not significant, consider alternative optimizations that do not compromise thread safety. [important]

    relevant line- loggerMu sync.Mutex

    relevant filegateway/middleware.go
    suggestion      

    For methods like SetName and SetRequestLogger that modify the logger, ensure that these changes are safe to perform in a concurrent environment, possibly by using atomic value setters or other concurrency-safe patterns. [important]

    relevant linet.logger = t.Logger().WithField("mw", name)

    relevant filegateway/middleware.go
    suggestion      

    Add comprehensive tests to verify that the removal of the mutex does not introduce race conditions or affect the functionality negatively, especially under high load. [medium]

    relevant linefunc (t BaseMiddleware) Base() *BaseMiddleware {


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
    When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    

    With a configuration file, use the following template:

    [pr_reviewer]
    some_config1=...
    some_config2=...
    
    Utilizing extra instructions

    The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

    Examples for extra instructions:

    [pr_reviewer] # /review #
    extra_instructions="""
    In the 'possible issues' section, emphasize the following:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    How to enable\disable automation
    • When you first install PR-Agent app, the default mode for the review tool is:
    pr_commands = ["/review", ...]
    

    meaning the review tool will run automatically on every PR, with the default configuration.
    Edit this field to enable/disable the tool, or to change the used configurations

    Auto-labels

    The review tool can auto-generate two specific types of labels for a PR:

    • a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
    • a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)
    Extra sub-tools

    The review tool provides a collection of possible feedbacks about a PR.
    It is recommended to review the possible options, and choose the ones relevant for your use case.
    Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
    require_score_review, require_soc2_ticket, and more.

    Auto-approve PRs

    By invoking:

    /review auto_approve
    

    The tool will automatically approve the PR, and add a comment with the approval.

    To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:

    [pr_reviewer]
    enable_auto_approval = true
    

    (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)

    You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:

    [pr_reviewer]
    maximal_review_effort = 5
    
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the review usage page for a comprehensive guide on using this tool.

    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Possible issue
    Reintroduce thread-safety for the logger in BaseMiddleware.

    Consider reintroducing thread-safety for the logger in BaseMiddleware. The removal of the
    mutex (loggerMu) and the lock operations could lead to race conditions when logger is
    accessed or modified concurrently. If the logger is meant to be accessed by multiple
    goroutines, using synchronization mechanisms is crucial to ensure thread safety.

    gateway/middleware.go [246-249]

    +import "sync"
    +
    +type BaseMiddleware struct {
    +    ...
    +    loggerMu sync.Mutex
    +    logger   *logrus.Entry
    +}
    +
     func (t *BaseMiddleware) Logger() (logger *logrus.Entry) {
    +    t.loggerMu.Lock()
    +    defer t.loggerMu.Unlock()
    +
         if t.logger == nil {
             t.logger = logrus.NewEntry(log)
         }
     
    Ensure thread-safety in SetName and SetRequestLogger by reintroducing mutex operations.

    The SetName and SetRequestLogger methods modify the logger field without any form of
    synchronization. Given that the Logger method previously contained mutex operations, it's
    likely that these logger modifications are expected to be thread-safe. Consider
    reintroducing the mutex for thread-safe operations or ensuring that these methods are
    called in a thread-safe manner.

    gateway/middleware.go [254-260]

     func (t *BaseMiddleware) SetName(name string) {
    +    t.loggerMu.Lock()
    +    defer t.loggerMu.Unlock()
         t.logger = t.Logger().WithField("mw", name)
     }
     
     func (t *BaseMiddleware) SetRequestLogger(r *http.Request) {
    +    t.loggerMu.Lock()
    +    defer t.loggerMu.Unlock()
         t.logger = t.Gw.getLogEntryForRequest(t.Logger(), r, ctxGetAuthToken(r), nil)
     }
     
    Enhancement
    Modify Base() to return a pointer to the receiver to allow modifications on the original instance.

    The Base() method in BaseMiddleware struct returns a pointer to a copy of the receiver.
    This could lead to unexpected behavior, as modifications to the returned BaseMiddleware
    instance won't affect the original. If the intention is to allow modifications on the
    original instance, consider returning a pointer to the receiver itself.

    gateway/middleware.go [242-244]

    -func (t BaseMiddleware) Base() *BaseMiddleware {
    -    return &t
    +func (t *BaseMiddleware) Base() *BaseMiddleware {
    +    return t
     }
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
    When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    

    With a configuration file, use the following template:

    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    
    Enabling\disabling automation

    When you first install the app, the default mode for the improve tool is:

    pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]
    

    meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

    Utilizing extra instructions

    Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project.

    Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on.

    Examples for extra instructions:

    [pr_code_suggestions] # /improve #
    extra_instructions="""
    Emphasize the following aspects:
    - Does the code logic cover relevant edge cases?
    - Is the code logic clear and easy to understand?
    - Is the code logic efficient?
    ...
    """
    

    Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

    A note on code suggestions quality
    • While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically.
    • Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base.
    • Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool
    • With large PRs, best quality will be obtained by using 'improve --extended' mode.
    More PR-Agent commands

    To invoke the PR-Agent, add a comment using one of the following commands:

    • /review: Request a review of your Pull Request.
    • /describe: Update the PR title and description based on the contents of the PR.
    • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
    • /ask <QUESTION>: Ask a question about the PR.
    • /update_changelog: Update the changelog based on the PR's contents.
    • /add_docs 💎: Generate docstring for new components introduced in the PR.
    • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
    • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

    See the tools guide for more details.
    To list the possible configuration parameters, add a /config comment.

    See the improve usage page for a more comprehensive guide on using this tool.

    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    API Changes

    --- prev.txt	2024-03-06 12:46:30.569588495 +0000
    +++ current.txt	2024-03-06 12:46:27.537585929 +0000
    @@ -7206,8 +7206,8 @@
     type BaseMiddleware struct {
     	Spec  *APISpec
     	Proxy ReturningHttpHandler
    -	Gw    *Gateway `json:"-"`
     
    +	Gw *Gateway `json:"-"`
     	// Has unexported fields.
     }
         BaseMiddleware wraps up the ApiSpec and Proxy objects to be included in a
    @@ -7217,7 +7217,7 @@
         ApplyPolicies will check if any policies are loaded. If any are, it will
         overwrite the session state to use the policy values.
     
    -func (t *BaseMiddleware) Base() *BaseMiddleware
    +func (t BaseMiddleware) Base() *BaseMiddleware
     
     func (t *BaseMiddleware) CheckSessionAndIdentityForValidKey(originalKey string, r *http.Request) (user.SessionState, bool)
         CheckSessionAndIdentityForValidKey will check first the Session store for a

    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    💥 CI tests failed 🙈

    git-state

    all ok

    Please look at the run or in the Checks tab.

    @padiazg padiazg left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @buger

    buger commented Mar 6, 2024

    Copy link
    Copy Markdown
    Member

    API tests result - postgres15-sha256 env: success
    Branch used: refs/heads/master
    Commit: bb3ad6a TT-11288 Revert logger mutex (#6103)

    User description

    Description

    Remove the mutex for the logger

    Related Issue

    TT-11288

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing
      functionality to change)
    • Refactoring or add test (improvements in base code or adds test
      coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning
      why it's required
    • I would like a code coverage CI quality gate exception and have
      explained why

    Type

    bug_fix


    Description

    • Removed the mutex lock from the logger in the BaseMiddleware struct
      to address potential performance issues and simplify the code.
    • Updated methods (Base(), Logger(), SetName(), and
      SetRequestLogger()) in BaseMiddleware to operate without mutex
      synchronization.

    Changes walkthrough

    Relevant files
    Bug fix
    middleware.go
    Remove Logger Mutex in BaseMiddleware                                       

    gateway/middleware.go

  • Removed mutex (sync.Mutex) for logger in BaseMiddleware struct.
  • Simplified Base(), Logger(), SetName(), and SetRequestLogger() methods
    by removing mutex locks and unlocks.
  • Ensured logger instance is directly manipulated without mutex
    synchronization.
  • +8/-32   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools
    and their descriptions
    Triggered by: push (@sredxny)
    Execution page

    @buger

    buger commented Mar 6, 2024

    Copy link
    Copy Markdown
    Member

    API tests result - mongo44-sha256 env: success
    Branch used: refs/heads/master
    Commit: bb3ad6a TT-11288 Revert logger mutex (#6103)

    User description

    Description

    Remove the mutex for the logger

    Related Issue

    TT-11288

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing
      functionality to change)
    • Refactoring or add test (improvements in base code or adds test
      coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning
      why it's required
    • I would like a code coverage CI quality gate exception and have
      explained why

    Type

    bug_fix


    Description

    • Removed the mutex lock from the logger in the BaseMiddleware struct
      to address potential performance issues and simplify the code.
    • Updated methods (Base(), Logger(), SetName(), and
      SetRequestLogger()) in BaseMiddleware to operate without mutex
      synchronization.

    Changes walkthrough

    Relevant files
    Bug fix
    middleware.go
    Remove Logger Mutex in BaseMiddleware                                       

    gateway/middleware.go

  • Removed mutex (sync.Mutex) for logger in BaseMiddleware struct.
  • Simplified Base(), Logger(), SetName(), and SetRequestLogger() methods
    by removing mutex locks and unlocks.
  • Ensured logger instance is directly manipulated without mutex
    synchronization.
  • +8/-32   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools
    and their descriptions
    Triggered by: push (@sredxny)
    Execution page

    @sredxny
    sredxny enabled auto-merge (squash) March 6, 2024 13:17
    @github-actions

    github-actions Bot commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor

    💥 CI tests failed 🙈

    git-state

    all ok

    Please look at the run or in the Checks tab.

    @sonarqubecloud

    sonarqubecloud Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Quality Gate Failed Quality Gate failed

    Failed conditions
    C Reliability Rating on New Code (required ≥ A)

    See analysis details on SonarCloud

    Catch issues before they fail your Quality Gate with our IDE extension SonarLint

    @sredxny
    sredxny merged commit bb3ad6a into master Mar 6, 2024
    @sredxny
    sredxny deleted the TT-11288-fix/memory-leak-remove-logger-lock branch March 6, 2024 13:43
    @sredxny

    sredxny commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor Author

    /release to release-5.2

    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Working on it! Note that it can take a few minutes.

    tykbot Bot pushed a commit that referenced this pull request Mar 6, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    (cherry picked from commit bb3ad6a)
    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    @sredxny Succesfully merged PR

    @sredxny

    sredxny commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor Author

    /release to release-5.3

    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Working on it! Note that it can take a few minutes.

    tykbot Bot pushed a commit that referenced this pull request Mar 6, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    (cherry picked from commit bb3ad6a)
    buger added a commit that referenced this pull request Mar 6, 2024
    TT-11288 Revert logger mutex (#6103)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    @sredxny Succesfully merged PR

    buger added a commit that referenced this pull request Mar 6, 2024
    TT-11288 Revert logger mutex (#6103)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    @sredxny

    sredxny commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor Author

    /release to release-5.3.0

    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Working on it! Note that it can take a few minutes.

    tykbot Bot pushed a commit that referenced this pull request Mar 6, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    (cherry picked from commit bb3ad6a)
    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    @sredxny Seems like there is conflict and it require manual merge.

    @buger

    buger commented Mar 6, 2024

    Copy link
    Copy Markdown
    Member

    API tests result - postgres15-murmur64 env: success
    Branch used: refs/heads/master
    Commit: bb3ad6a TT-11288 Revert logger mutex (#6103)

    User description

    Description

    Remove the mutex for the logger

    Related Issue

    TT-11288

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing
      functionality to change)
    • Refactoring or add test (improvements in base code or adds test
      coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning
      why it's required
    • I would like a code coverage CI quality gate exception and have
      explained why

    Type

    bug_fix


    Description

    • Removed the mutex lock from the logger in the BaseMiddleware struct
      to address potential performance issues and simplify the code.
    • Updated methods (Base(), Logger(), SetName(), and
      SetRequestLogger()) in BaseMiddleware to operate without mutex
      synchronization.

    Changes walkthrough

    Relevant files
    Bug fix
    middleware.go
    Remove Logger Mutex in BaseMiddleware                                       

    gateway/middleware.go

  • Removed mutex (sync.Mutex) for logger in BaseMiddleware struct.
  • Simplified Base(), Logger(), SetName(), and SetRequestLogger() methods
    by removing mutex locks and unlocks.
  • Ensured logger instance is directly manipulated without mutex
    synchronization.
  • +8/-32   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools
    and their descriptions
    Triggered by: push (@sredxny)
    Execution page

    @buger

    buger commented Mar 6, 2024

    Copy link
    Copy Markdown
    Member

    API tests result - mongo44-murmur64 env: success
    Branch used: refs/heads/master
    Commit: bb3ad6a TT-11288 Revert logger mutex (#6103)

    User description

    Description

    Remove the mutex for the logger

    Related Issue

    TT-11288

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing
      functionality to change)
    • Refactoring or add test (improvements in base code or adds test
      coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning
      why it's required
    • I would like a code coverage CI quality gate exception and have
      explained why

    Type

    bug_fix


    Description

    • Removed the mutex lock from the logger in the BaseMiddleware struct
      to address potential performance issues and simplify the code.
    • Updated methods (Base(), Logger(), SetName(), and
      SetRequestLogger()) in BaseMiddleware to operate without mutex
      synchronization.

    Changes walkthrough

    Relevant files
    Bug fix
    middleware.go
    Remove Logger Mutex in BaseMiddleware                                       

    gateway/middleware.go

  • Removed mutex (sync.Mutex) for logger in BaseMiddleware struct.
  • Simplified Base(), Logger(), SetName(), and SetRequestLogger() methods
    by removing mutex locks and unlocks.
  • Ensured logger instance is directly manipulated without mutex
    synchronization.
  • +8/-32   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools
    and their descriptions
    Triggered by: push (@sredxny)
    Execution page

    sredxny added a commit that referenced this pull request Mar 6, 2024
    TT-11288 Revert logger mutex (#6103)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    Co-authored-by: Sredny M <[email protected]>
    @sredxny

    sredxny commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor Author

    /release to release-5-lts

    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Working on it! Note that it can take a few minutes.

    tykbot Bot pushed a commit that referenced this pull request Mar 6, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    (cherry picked from commit bb3ad6a)
    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    @sredxny Succesfully merged PR

    @sredxny

    sredxny commented Mar 6, 2024

    Copy link
    Copy Markdown
    Contributor Author

    /release to release-5.0.11

    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    Working on it! Note that it can take a few minutes.

    tykbot Bot pushed a commit that referenced this pull request Mar 6, 2024
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    
    (cherry picked from commit bb3ad6a)
    @tykbot

    tykbot Bot commented Mar 6, 2024

    Copy link
    Copy Markdown

    @sredxny Succesfully merged PR

    buger added a commit that referenced this pull request Mar 6, 2024
    TT-11288 Revert logger mutex (#6103)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    buger added a commit that referenced this pull request Mar 6, 2024
    TT-11288 Revert logger mutex (#6103)
    
    ## **User description**
    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    Remove the mutex for the  logger 
    
    ## Related Issue
    
    TT-11288
    
    ## Motivation and Context
    
    <!-- Why is this change required? What problem does it solve? -->
    
    ## How This Has Been Tested
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    ## Checklist
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    
    ___
    
    ## **Type**
    bug_fix
    
    
    ___
    
    ## **Description**
    - Removed the mutex lock from the logger in the `BaseMiddleware` struct
    to address potential performance issues and simplify the code.
    - Updated methods (`Base()`, `Logger()`, `SetName()`, and
    `SetRequestLogger()`) in `BaseMiddleware` to operate without mutex
    synchronization.
    
    
    ___
    
    
    
    ## **Changes walkthrough**
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Bug
    fix</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>middleware.go</strong><dd><code>Remove Logger Mutex in
    BaseMiddleware</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    gateway/middleware.go
    <li>Removed mutex (<code>sync.Mutex</code>) for logger in
    <code>BaseMiddleware</code> struct.<br> <li> Simplified
    <code>Base()</code>, <code>Logger()</code>, <code>SetName()</code>, and
    <code>SetRequestLogger()</code> methods <br>by removing mutex locks and
    unlocks.<br> <li> Ensured logger instance is directly manipulated
    without mutex <br>synchronization.
    
    
    </details>
        
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6103/files#diff-703054910891a4db633eca0f42ed779d6b4fa75cd9b3aa4c503e681364201c1b">+8/-32</a>&nbsp;
    &nbsp; </td>
    </tr>                    
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > ✨ **PR-Agent usage**:
    >Comment `/help` on the PR to get a list of all available PR-Agent tools
    and their descriptions
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants