[TT-11389]: moved graphql span attributes#6088
Conversation
|
PR Description updated to latest commit (90f7569) |
|
API Changes no api changes detected |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview: With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index 7b5c8e3..173f860 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
1 similar comment
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index 7b5c8e3..173f860 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
|
API tests result - postgres15-sha256 env: success ✅ User descriptionmoved the document info attributes for graphql requests to the DescriptionMoved the graphql-specific span attributes higher up the span chain so Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
Typeenhancement Description
Changes walkthrough
|
|
API tests result - mongo44-sha256 env: success ✅ User descriptionmoved the document info attributes for graphql requests to the DescriptionMoved the graphql-specific span attributes higher up the span chain so Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
Typeenhancement Description
Changes walkthrough
|
90f7569 to
a4f5916
Compare
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index 7b5c8e3..173f860 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
a4f5916 to
34c8882
Compare
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index 7b5c8e3..173f860 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
1 similar comment
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index 7b5c8e3..173f860 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
34c8882 to
4d40caa
Compare
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index d0a7d37..58863d9 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index d0a7d37..58863d9 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
4d40caa to
0412775
Compare
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index d0a7d37..58863d9 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
0412775 to
682090a
Compare
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index d0a7d37..58863d9 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
1 similar comment
💥 CI tests failed 🙈git-statediff --git a/internal/graphengine/engine_v2.go b/internal/graphengine/engine_v2.go
index d0a7d37..58863d9 100644
--- a/internal/graphengine/engine_v2.go
+++ b/internal/graphengine/engine_v2.go
@@ -3,9 +3,10 @@ package graphengine
import (
"context"
"errors"
+ "net/http"
+
"github.com/TykTechnologies/graphql-go-tools/pkg/ast"
semconv "github.com/TykTechnologies/opentelemetry/semconv/v1.0.0"
- "net/http"
"github.com/jensneuse/abstractlogger"
"github.com/sirupsen/logrus"Please look at the run or in the Checks tab. |
682090a to
e5096b9
Compare
💥 CI tests failed 🙈git-stateall okPlease look at the run or in the Checks tab. |
moved the document info attributes for graphql requests to the GraphqlMiddlewareValidation span
42a1f7c to
4385a0a
Compare
|
|
API tests result - mongo44-murmur64 env: success ✅ User descriptionmoved the document info attributes for graphql requests to the DescriptionMoved the graphql-specific span attributes higher up the span chain so Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
Typeenhancement Description
Changes walkthrough
|
|
API tests result - postgres15-murmur64 env: success ✅ User descriptionmoved the document info attributes for graphql requests to the DescriptionMoved the graphql-specific span attributes higher up the span chain so Related IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
Typeenhancement Description
Changes walkthrough
|
|
/release to release-5.3 |
|
Working on it! Note that it can take a few minutes. |
## **User description** moved the document info attributes for graphql requests to the GraphqlMiddlewareValidation span <!-- Provide a general summary of your changes in the Title above --> ## Description Moved the graphql-specific span attributes higher up the span chain so they can still be seen in the event of a request failure when detailed tracing is turned on [TT-11389](https://tyktech.atlassian.net/browse/TT-11389) <!-- Describe your changes in detail --> ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-11389]: https://tyktech.atlassian.net/browse/TT-11389?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ## **Type** enhancement ___ ## **Description** - Added OpenTelemetry semantic conventions for GraphQL operation name, type, and document in `ProcessAndStoreGraphQLRequest` method to enhance tracing capabilities. - Refactored the way GraphQL operation type is determined and set on spans across different parts of the codebase. - Removed redundant span attributes setting in the `ValidateForSchema` method of the detailed GraphQL engine. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>engine_v2.go</strong><dd><code>Add OpenTelemetry Attributes for GraphQL Requests</code> </dd></summary> <hr> internal/graphengine/engine_v2.go <li>Added OpenTelemetry semantic conventions for GraphQL in <br><code>ProcessAndStoreGraphQLRequest</code> method.<br> <li> Set attributes for GraphQL operation name, type, and document on the <br>span. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-b1eaa954c9836f395e1d49090e85c739e3878747c8bd748f556fc5a53ff7b191">+13/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>otel_graphql_engine_basic.go</strong><dd><code>Use PrintOperationType for Span Attributes</code> </dd></summary> <hr> internal/graphql/otel_graphql_engine_basic.go <li>Modified to use <code>PrintOperationType</code> for setting GraphQL operation type <br>attribute on the span. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-d2e2ab0951855338accb48c6985c5f880a8ea2746872c7cea5b64f308a5214c8">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>otel_graphql_engine_detailed.go</strong><dd><code>Refactor Span Attributes Setting in GraphQL Engine</code> </dd></summary> <hr> internal/graphql/otel_graphql_engine_detailed.go <li>Removed span attributes setting from <code>ValidateForSchema</code> method.<br> <li> Exposed <code>PrintOperationType</code> function for external use. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-799c8fc0e5c351c4903c0ecfcc1b9997473f469edcd25118edf447dc6ea4e771">+2/-15</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions (cherry picked from commit 5ce6148)
|
@kofoworola Seems like there is conflict and it require manual merge. |
) (#6129) ## **User description** [TT-11389]: moved graphql span attributes (#6088) ## **User description** moved the document info attributes for graphql requests to the GraphqlMiddlewareValidation span <!-- Provide a general summary of your changes in the Title above --> ## Description Moved the graphql-specific span attributes higher up the span chain so they can still be seen in the event of a request failure when detailed tracing is turned on [TT-11389](https://tyktech.atlassian.net/browse/TT-11389) <!-- Describe your changes in detail --> ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why [TT-11389]: https://tyktech.atlassian.net/browse/TT-11389?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ## **Type** enhancement ___ ## **Description** - Added OpenTelemetry semantic conventions for GraphQL operation name, type, and document in `ProcessAndStoreGraphQLRequest` method to enhance tracing capabilities. - Refactored the way GraphQL operation type is determined and set on spans across different parts of the codebase. - Removed redundant span attributes setting in the `ValidateForSchema` method of the detailed GraphQL engine. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>engine_v2.go</strong><dd><code>Add OpenTelemetry Attributes for GraphQL Requests</code> </dd></summary> <hr> internal/graphengine/engine_v2.go <li>Added OpenTelemetry semantic conventions for GraphQL in <br><code>ProcessAndStoreGraphQLRequest</code> method.<br> <li> Set attributes for GraphQL operation name, type, and document on the <br>span. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-b1eaa954c9836f395e1d49090e85c739e3878747c8bd748f556fc5a53ff7b191">+13/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>otel_graphql_engine_basic.go</strong><dd><code>Use PrintOperationType for Span Attributes</code> </dd></summary> <hr> internal/graphql/otel_graphql_engine_basic.go <li>Modified to use <code>PrintOperationType</code> for setting GraphQL operation type <br>attribute on the span. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-d2e2ab0951855338accb48c6985c5f880a8ea2746872c7cea5b64f308a5214c8">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>otel_graphql_engine_detailed.go</strong><dd><code>Refactor Span Attributes Setting in GraphQL Engine</code> </dd></summary> <hr> internal/graphql/otel_graphql_engine_detailed.go <li>Removed span attributes setting from <code>ValidateForSchema</code> method.<br> <li> Exposed <code>PrintOperationType</code> function for external use. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6088/files#diff-799c8fc0e5c351c4903c0ecfcc1b9997473f469edcd25118edf447dc6ea4e771">+2/-15</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions [TT-11389]: https://tyktech.atlassian.net/browse/TT-11389?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [TT-11389]: https://tyktech.atlassian.net/browse/TT-11389?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [TT-11389]: https://tyktech.atlassian.net/browse/TT-11389?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ ___ ## **Type** enhancement, tests ___ ## **Description** - Enhanced error handling in GraphQL normalization and validation by setting detailed span attributes upon failure. - Refactored operation type utility for broader usage across the codebase. - Updated Docker build command in Makefile. - Added new tracing test scenarios for GraphQL, including handling of invalid requests and detailed tracing disabled cases. ___ ## **Changes walkthrough** <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>otel_graphql_engine_basic.go</strong><dd><code>Enhance GraphQL Span Attributes and Error Handling</code> </dd></summary> <hr> internal/graphql/otel_graphql_engine_basic.go <li>Added error handling to set GraphQL span attributes upon normalization <br>failure.<br> <li> Enhanced operation type extraction and error handling. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-d2e2ab0951855338accb48c6985c5f880a8ea2746872c7cea5b64f308a5214c8">+18/-2</a> </td> </tr> <tr> <td> <details> <summary><strong>otel_graphql_engine_detailed.go</strong><dd><code>Improve Error Handling and Refactor Operation Type Utility</code></dd></summary> <hr> internal/graphql/otel_graphql_engine_detailed.go <li>Improved normalization and validation error handling with detailed <br>span attributes.<br> <li> Refactored <code>printOperationType</code> to <code>PrintOperationType</code> for broader usage. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-799c8fc0e5c351c4903c0ecfcc1b9997473f469edcd25118edf447dc6ea4e771">+10/-3</a> </td> </tr> </table></td></tr><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>opentelemetry.yml</strong><dd><code>Add New Tracing Test Scenarios for GraphQL</code> </dd></summary> <hr> .taskfiles/opentelemetry.yml <li>Added new tracing test scenarios for GraphQL with detailed tracing <br>disabled. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-3a4b761dd20bd83804466e1295ad58db13b87b5e35e6120efc59c2b7bfaa27e1">+2/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>tyk_test-graphql-detailed-tracing-disabled_400.yaml</strong><dd><code>New Test Scenario for GraphQL Detailed Tracing with Invalid Request</code></dd></summary> <hr> ci/tests/tracing/scenarios/tyk_test-graphql-detailed-tracing-disabled_400.yaml <li>Introduced a new test scenario for GraphQL detailed tracing with <br>invalid request. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-66d2f9c1731064ac100ea574a98a12c3847abad914d5e8e61e7d9b69c1cafca2">+21/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>tyk_test-graphql-tracing_200.yml</strong><dd><code>Modify Assertions for GraphQL Operation Details Validation</code></dd></summary> <hr> ci/tests/tracing/scenarios/tyk_test-graphql-tracing_200.yml <li>Modified assertions to correctly validate GraphQL operation details. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-2df94df431a444a3778f2b00fd47d911dcfa2e0c9c883de72f72adcd509c890a">+6/-9</a> </td> </tr> <tr> <td> <details> <summary><strong>tyk_test-graphql-tracing_400.yml</strong><dd><code>New Test Scenario for Bad GraphQL Request Tracing</code> </dd></summary> <hr> ci/tests/tracing/scenarios/tyk_test-graphql-tracing_400.yml - Added a test scenario for handling bad GraphQL requests in tracing. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-ff037bf3b758b91e239d4f0c5d9af67062c7e4d18a895713c9e14e38b04d108f">+20/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>Makefile</strong><dd><code>Update Docker Build Command</code> </dd></summary> <hr> Makefile - Updated Docker build command. </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6129/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52">+1/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > ✨ **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: Kofo Okesola <[email protected]>
3 participants
User description
moved the document info attributes for graphql requests to the GraphqlMiddlewareValidation span
Description
Moved the graphql-specific span attributes higher up the span chain so they can still be seen in the event of a request failure when detailed tracing is turned on
TT-11389
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
Type
enhancement
Description
ProcessAndStoreGraphQLRequestmethod to enhance tracing capabilities.ValidateForSchemamethod of the detailed GraphQL engine.Changes walkthrough
engine_v2.go
Add OpenTelemetry Attributes for GraphQL Requestsinternal/graphengine/engine_v2.go
ProcessAndStoreGraphQLRequestmethod.span.
otel_graphql_engine_basic.go
Use PrintOperationType for Span Attributesinternal/graphql/otel_graphql_engine_basic.go
PrintOperationTypefor setting GraphQL operation typeattribute on the span.
otel_graphql_engine_detailed.go
Refactor Span Attributes Setting in GraphQL Engineinternal/graphql/otel_graphql_engine_detailed.go
ValidateForSchemamethod.PrintOperationTypefunction for external use.