[TT-6011] Fix non-functional coprocess apis, add tests by titpetric · Pull Request #4055 · TykTechnologies/tyk

titpetric · 2022-05-17T11:57:34Z

Description

This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes.

https://tyktech.atlassian.net/browse/TT-6011

Motivation and Context

Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage.

How This Has Been Tested

$ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v .
[May 17 13:54:52] DEBUG Using serializer protobuf for analytics 

=== RUN   TestCoprocessAPIs
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool"
time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client"
--- PASS: TestCoprocessAPIs (0.02s)
=== RUN   TestCoprocessLog
time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python
time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python
time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python
time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python
--- PASS: TestCoprocessLog (0.00s)
=== RUN   TestCoprocessSystemEvent
--- PASS: TestCoprocessSystemEvent (0.00s)
PASS
ok  	github.com/TykTechnologies/tyk/gateway	0.048s

Before? No tests.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

Final note for review

These functions need to access the gateway config (e.g. load it). Currently, I'm only passing &config.Config{} to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;)

Tyk-ITS · 2022-05-17T12:17:37Z

API tests result: skipped 🚫
Branch used: refs/pull/4055/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

Tyk-ITS · 2022-05-17T12:42:12Z

API tests result: skipped 🚫
Branch used: refs/pull/4055/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

Tyk-ITS · 2022-05-17T14:08:02Z

API tests result: skipped 🚫
Branch used: refs/pull/4055/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

Tyk-ITS · 2022-05-18T08:48:41Z

API tests result: failure 🚫
Branch used: refs/pull/4055/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

Tyk-ITS · 2022-05-18T11:24:31Z

API tests result: success ✅
Branch used: refs/pull/4055/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

sonarqubecloud · 2022-05-18T14:41:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.1% Coverage
0.0% Duplication

Tyk-ITS · 2022-05-18T14:42:28Z

API tests result: success ✅
Branch used: refs/pull/4055/merge
Commit: c810f4a
Triggered by: pull_request (@titpetric)
Execution page

titpetric · 2022-06-09T08:27:39Z

@matiasinsaurralde hey, would you be so kind to review. I added the test cases for the coprocess bindings, and fixed a flaky test in the process (race condition when connecting to redis). It also fixes a leak of the redis connection with a ctx cancellation.

If this isn't in use, I'd be happy to delete this

titpetric · 2022-08-17T18:50:09Z

cc @ermirizio @buger I'm asuming the referenced PR above is going to be orphaned and/or somebody needs to pick up this. I am/was happy with my proposed diff here, but we can look to merge the two PR improvements. I'm fine picking this up if there isn't something in the works already

ermirizio · 2022-08-17T19:01:41Z

@titpetric I'm afraid I can't audit the code this time since is not within my expertise, I'm more like an stakeholder for this since we'll need this and the referenced PR to get our plugin for OIDC to work. https://tyktech.atlassian.net/browse/TD-1088 . It'll be great if you could take this so we get unblocked :)

lghiur · 2022-11-17T06:54:39Z

@titpetric is this still needed?

github-actions · 2024-03-22T08:18:55Z

API Changes

no api changes detected

github-actions · 2024-03-22T08:23:16Z

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

github-actions · 2024-03-22T08:28:55Z

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

github-actions · 2024-03-22T08:56:35Z

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

sonarqubecloud · 2024-03-22T09:49:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

titpetric · 2024-03-22T10:37:55Z

/release to release-5.3

tykbot · 2024-03-22T10:38:26Z

Working on it! Note that it can take a few minutes.

## Description This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes. https://tyktech.atlassian.net/browse/TT-6011 ## Motivation and Context Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage. ## How This Has Been Tested ``` $ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v . [May 17 13:54:52] DEBUG Using serializer protobuf for analytics === RUN TestCoprocessAPIs time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" --- PASS: TestCoprocessAPIs (0.02s) === RUN TestCoprocessLog time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python --- PASS: TestCoprocessLog (0.00s) === RUN TestCoprocessSystemEvent --- PASS: TestCoprocessSystemEvent (0.00s) PASS ok github.com/TykTechnologies/tyk/gateway 0.048s ``` Before? No tests. ## Types of changes  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist   - [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Check your code additions will not fail linting checks: - [ ] `go fmt -s` - [ ] `go vet` ## Final note for review These functions need to access the gateway config (e.g. load it). Currently, I'm only passing `&config.Config{}` to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;) --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 9cb8304)

tykbot · 2024-03-22T10:38:45Z

@titpetric Succesfully merged PR

…add tests (#4055) [TT-6011] Fix non-functional coprocess apis, add tests (#4055) ## Description This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes. https://tyktech.atlassian.net/browse/TT-6011 ## Motivation and Context Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage. ## How This Has Been Tested ``` $ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v . [May 17 13:54:52] DEBUG Using serializer protobuf for analytics === RUN TestCoprocessAPIs time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" --- PASS: TestCoprocessAPIs (0.02s) === RUN TestCoprocessLog time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python --- PASS: TestCoprocessLog (0.00s) === RUN TestCoprocessSystemEvent --- PASS: TestCoprocessSystemEvent (0.00s) PASS ok github.com/TykTechnologies/tyk/gateway 0.048s ``` Before? No tests. ## Types of changes  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist   - [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Check your code additions will not fail linting checks: - [ ] `go fmt -s` - [ ] `go vet` ## Final note for review These functions need to access the gateway config (e.g. load it). Currently, I'm only passing `&config.Config{}` to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;) --------- Co-authored-by: Tit Petric <[email protected]>

titpetric · 2024-03-22T10:38:55Z

/release to release-5-lts

tykbot · 2024-03-22T10:40:04Z

Working on it! Note that it can take a few minutes.

This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes. https://tyktech.atlassian.net/browse/TT-6011 Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage. ``` $ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v . [May 17 13:54:52] DEBUG Using serializer protobuf for analytics === RUN TestCoprocessAPIs time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" --- PASS: TestCoprocessAPIs (0.02s) === RUN TestCoprocessLog time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python --- PASS: TestCoprocessLog (0.00s) === RUN TestCoprocessSystemEvent --- PASS: TestCoprocessSystemEvent (0.00s) PASS ok github.com/TykTechnologies/tyk/gateway 0.048s ``` Before? No tests.  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality)   - [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Check your code additions will not fail linting checks: - [ ] `go fmt -s` - [ ] `go vet` These functions need to access the gateway config (e.g. load it). Currently, I'm only passing `&config.Config{}` to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;) --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 9cb8304)

tykbot · 2024-03-22T10:40:23Z

@titpetric Succesfully merged PR

This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes. https://tyktech.atlassian.net/browse/TT-6011 Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage. ``` $ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v . [May 17 13:54:52] DEBUG Using serializer protobuf for analytics === RUN TestCoprocessAPIs time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" --- PASS: TestCoprocessAPIs (0.02s) === RUN TestCoprocessLog time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python --- PASS: TestCoprocessLog (0.00s) === RUN TestCoprocessSystemEvent --- PASS: TestCoprocessSystemEvent (0.00s) PASS ok github.com/TykTechnologies/tyk/gateway 0.048s ``` Before? No tests.  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality)   - [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Check your code additions will not fail linting checks: - [ ] `go fmt -s` - [ ] `go vet` These functions need to access the gateway config (e.g. load it). Currently, I'm only passing `&config.Config{}` to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;) --------- Co-authored-by: Tit Petric <[email protected]> (cherry picked from commit 9cb8304)

…, add tests (#4055) (#6179) [TT-6011] Fix non-functional coprocess apis, add tests (#4055) ## Description This PR adds test for the coprocess StoreData and GetData apis. It fixes an issue with the redis connection and updates use to latest storage package changes. https://tyktech.atlassian.net/browse/TT-6011 ## Motivation and Context Coprocess APIs don't connect to redis, don't have timeouts. I fixed opening the Redis connection, added unit tests to verify functionality and add code coverage. ## How This Has Been Tested ``` $ TYK_LOGLEVEL=debug go test -run=TestCoprocess -v . [May 17 13:54:52] DEBUG Using serializer protobuf for analytics === RUN TestCoprocessAPIs time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" time="May 17 13:54:52" level=debug msg="Creating new Redis connection pool" time="May 17 13:54:52" level=info msg="--> [REDIS] Creating single-node client" --- PASS: TestCoprocessAPIs (0.02s) === RUN TestCoprocessLog time="May 17 13:54:52" level=debug msg="test logging message 0" prefix=python time="May 17 13:54:52" level=error msg="test logging message 1" prefix=python time="May 17 13:54:52" level=warning msg="test logging message 2" prefix=python time="May 17 13:54:52" level=info msg="test logging message 3" prefix=python --- PASS: TestCoprocessLog (0.00s) === RUN TestCoprocessSystemEvent --- PASS: TestCoprocessSystemEvent (0.00s) PASS ok github.com/TykTechnologies/tyk/gateway 0.048s ``` Before? No tests. ## Types of changes  - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist   - [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [ ] My change requires a change to the documentation. - [ ] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Check your code additions will not fail linting checks: - [ ] `go fmt -s` - [ ] `go vet` ## Final note for review These functions need to access the gateway config (e.g. load it). Currently, I'm only passing `&config.Config{}` to use defaults, which works for tests but won't work on a custom-configured gateway instance. Need to get the actual config. How? ;) --------- Co-authored-by: Tit Petric <[email protected]> [TT-6011]: https://tyktech.atlassian.net/browse/TT-6011?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Tit Petric <[email protected]> Co-authored-by: Tit Petric <[email protected]>

TykTechnologies deleted a comment from github-actions Bot May 17, 2022

titpetric marked this pull request as ready for review May 18, 2022 14:26

titpetric force-pushed the fix/coprocess-tests-and-code-coverage branch from 356798e to c810f4a Compare May 18, 2022 14:27

titpetric requested review from furkansenharputlu, jeffy-mathew, mitjaziv and urbanishimwe May 19, 2022 08:11

furkansenharputlu reviewed Jun 9, 2022

View reviewed changes

Comment thread gateway/coprocess_api.go

titpetric requested a review from matiasinsaurralde June 9, 2022 08:13

titpetric changed the title ~~Fix non-functional coprocess apis, add tests~~ [TT-5498] Fix non-functional coprocess apis, add tests Jun 9, 2022

titpetric mentioned this pull request Jul 26, 2022

[TT-6159] coprocess: add tests for Tyk cgo API and expose GW RedisController for CP functionality #4205

Closed

17 tasks

Fix non-functional coprocess apis, add tests

c91ef40

titpetric force-pushed the fix/coprocess-tests-and-code-coverage branch from c810f4a to c91ef40 Compare March 22, 2024 08:18

Update connection func

ccadfbb

mitjaziv removed request for matiasinsaurralde, mitjaziv and urbanishimwe March 22, 2024 08:24

Tit Petric added 2 commits March 22, 2024 09:31

Update usage for storage

107cf09

Move storage for python into helper fn

3557880

jeffy-mathew approved these changes Mar 22, 2024

View reviewed changes

TestResponseOverride: remove flaky

9b08506

titpetric changed the title ~~[TT-5498] Fix non-functional coprocess apis, add tests~~ [TT-6011] Fix non-functional coprocess apis, add tests Mar 22, 2024

titpetric merged commit 9cb8304 into master Mar 22, 2024

titpetric deleted the fix/coprocess-tests-and-code-coverage branch March 22, 2024 10:37

buger mentioned this pull request Mar 22, 2024

Merging to release-5.3: [TT-6011] Fix non-functional coprocess apis, add tests (#4055) #6178

Merged

17 tasks

buger mentioned this pull request Mar 22, 2024

Merging to release-5-lts: [TT-6011] Fix non-functional coprocess apis, add tests (#4055) #6179

Merged

17 tasks

Uh oh!

Conversation

titpetric commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How This Has Been Tested

Types of changes

Checklist

Final note for review

Uh oh!

Tyk-ITS commented May 17, 2022

Uh oh!

Tyk-ITS commented May 17, 2022

Uh oh!

Tyk-ITS commented May 17, 2022

Uh oh!

Tyk-ITS commented May 18, 2022

Uh oh!

Tyk-ITS commented May 18, 2022

Uh oh!

sonarqubecloud Bot commented May 18, 2022

Uh oh!

Tyk-ITS commented May 18, 2022

Uh oh!

Uh oh!

titpetric commented Jun 9, 2022

Uh oh!

titpetric commented Aug 17, 2022

Uh oh!

ermirizio commented Aug 17, 2022

Uh oh!

lghiur commented Nov 17, 2022

Uh oh!

github-actions Bot commented Mar 22, 2024

Uh oh!

github-actions Bot commented Mar 22, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

github-actions Bot commented Mar 22, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

github-actions Bot commented Mar 22, 2024

💥 CI tests failed 🙈

git-state

Uh oh!

sonarqubecloud Bot commented Mar 22, 2024

Quality Gate passed

Uh oh!

titpetric commented Mar 22, 2024

Uh oh!

tykbot Bot commented Mar 22, 2024

Uh oh!

tykbot Bot commented Mar 22, 2024

Uh oh!

titpetric commented Mar 22, 2024

Uh oh!

tykbot Bot commented Mar 22, 2024

Uh oh!

tykbot Bot commented Mar 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

titpetric commented May 17, 2022 •

edited

Loading