…cache bug (#298) Issue: #300 ## Changes - Set `allow-unused: true` for `nolintlint` in `.golangci.yml` to prevent flaky CI failures ## Notes ### Problem The `lint-go` CI job intermittently fails with errors like: ``` directive `//nolint:ireturn` is unused for linter "ireturn" (nolintlint) ``` **Evidence**: [Failed CI run](https://github.com/Twingate/gateway/actions/runs/26206509968/job/77107441411?pr=296) ### Root Cause This is a [known golangci-lint bug](golangci/golangci-lint#3228) where the internal linter cache loses analysis facts (in our case, `ireturn` violations) across runs. When this happens: 1. `ireturn` violations become invisible due to stale/partial cache 2. `nolintlint` checks whether each `//nolint` directive suppresses a real violation 3. With the cached facts missing, `nolintlint` concludes the directive is "unused" and flags it 4. With `--fix` enabled (as in `make lint`), these "unused" directives get silently deleted 5. The next clean run sees the real violations again and fails The bug is flaky — it depends on which cache entries are evicted, so it affects a different subset of directives each time. It is more likely in CI where the GitHub Actions cache is restored from previous runs against different code states. ### Fix Following the same [workaround adopted by cloudnative-pg](cloudnative-pg/cloudnative-pg#10136), we set `allow-unused: true` for `nolintlint` to tolerate potentially "unused" nolint directives rather than falsely flagging them. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Fix: Work around nolintlint false positives from golangci-lint cache bug #300

Description

Activity

linear commented on May 21, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions