Skip to content

Enhancing Path Consistency in PR #2812#2853

Merged
la-xirsoi merged 1 commit intoTuxemon:developmentfrom
JaskRendix:locale
Jun 20, 2025
Merged

Enhancing Path Consistency in PR #2812#2853
la-xirsoi merged 1 commit intoTuxemon:developmentfrom
JaskRendix:locale

Conversation

@JaskRendix
Copy link
Copy Markdown
Collaborator

@JaskRendix JaskRendix commented Jun 11, 2025

PR builds on the groundwork established in #2812, refining the transition to Path objects across the codebase. The previous implementation left some inconsistencies where Path objects were converted to str and later transformed back into Path, disrupting continuity. These unnecessary conversions have now been eliminated, ensuring that Path is consistently passed to various methods.

The remaining task is to address the fetch function (prepare.py), which must be updated to both accept and return Path objects. However, modifying fetch will require changes to files that are already affected by pending PRs, making it a separate step in this ongoing effort. This update furthers the overall goal of full Path integration.

@JaskRendix JaskRendix marked this pull request as ready for review June 11, 2025 11:58
@JaskRendix JaskRendix changed the title Enhancing Path Consistency in PR #2851 Enhancing Path Consistency in PR #2812 Jun 11, 2025
@la-xirsoi la-xirsoi merged commit 0aee65e into Tuxemon:development Jun 20, 2025
10 checks passed
@JaskRendix JaskRendix deleted the locale branch June 20, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants