Enhancing Path Consistency in PR #2812#2853
Merged
la-xirsoi merged 1 commit intoTuxemon:developmentfrom Jun 20, 2025
Merged
Conversation
1 task
la-xirsoi
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR builds on the groundwork established in #2812, refining the transition to
Pathobjects across the codebase. The previous implementation left some inconsistencies wherePathobjects were converted tostrand later transformed back intoPath, disrupting continuity. These unnecessary conversions have now been eliminated, ensuring thatPathis consistently passed to various methods.The remaining task is to address the
fetchfunction (prepare.py), which must be updated to both accept and returnPathobjects. However, modifyingfetchwill require changes to files that are already affected by pending PRs, making it a separate step in this ongoing effort. This update furthers the overall goal of fullPathintegration.