Use PhantomJS 2.1.1 on Travis#6051
Conversation
|
This is cool, I look forward to it being available. I'd imagine it would be way more reliable using 2.0 for our tests seeing as our layout relies on flexbox so heavily. |
|
Looks like there's movement on the 2.0.1/2.1 release so hopefully shouldn't be too long now https://groups.google.com/forum/#!topic/phantomjs-dev/vkdGvFpULNo |
|
Hey so phantomjs 2.1 (and 2.1.1) was released yesterday. It also looks like all the compiled binary issues have been fixed as well 😄 |
|
@acburdine Awesome, I think before we rush this in it would be good to run 2.1 locally for a while so that we can catch any differences or issues. I'll be installing 2.1 later, would you mind doing that too? I think medium-term it would be better to switch Travis to testing with Chrome (and other browsers) as that will always be much closer to real-life than phantomjs. |
|
Yeah I can do that. I'm not sure how to test with Chrome in Travis, but sounds like a good plan 👍 Also (this is just me thinking out loud), what about using Saucelabs testing? |
|
Yep, saucelabs is definitely on the cards too. We may need to look into splitting the repositories as the client testing gets more involved because Travis' matrix really doesn't cover the multi-project same-repo use case well. |
kevinansfield
force-pushed
the
phantomjs2
branch
from
09fa283 to
bf60b6d
Compare
|
PhantomJS 2.1.x was recently released which resolves the OS X compilation issues. We've also started to run into phantomjs 1.9.x issues with our tests so I think the time is right to look at this again (TBH I'm surprised they are working at all with our heavy use of flexbox!). I've updated the PR to use the new version, tests seem to be running fine on Travis. |
no issue - download phantomjs 2.1.1 in Travis' `before_install` step and update the `PATH` export to so the downloaded version is used - remove the now no-longer needed `ember-cli-es5-shim` dependency - update documentation references to match new phantomjs version
kevinansfield
force-pushed
the
phantomjs2
branch
from
bf60b6d to
672396d
Compare
|
LGTM 👍 And based on the testing I've done locally with phantomjs, it does seem a decent amount faster. |
3 participants
no issue
before_installstep and update thePATHexport to so the downloaded version is usedember-cli-es5-shimdependencySeeing as we've now dropped the Casper.js suite I figured we should try upgrading to phantomjs 2.0 as it's recommended by Ember, uses a much newer version of webkit and is supposedly faster.
I don't think it's quite ready for general use yet as I ran into a couple of issues when trying this out:
Travis does not yet support phantomjs 2.0 by default but that should be coming soon - Add support for PhantomJS 2.0 travis-ci/travis-ci#3225- easily resolved by downloading/building the version we want in Travis'before_installhookPhantomjs won't currently install via homebrew on OS X versions later than Yosemite, there is a 2.0.1 preview with the issues fixed which should make it's way through the pipeline shortly. Binaries are available for install at https://github.com/Vitallium/phantomjs/releases/tag/2.0.1- The newly released version 2.1.x is now installable via homebrew