🐛 Fixed uploads of m4a files with audio/mp4 content type#16342
Merged
daniellockyer merged 1 commit intoTryGhost:mainfrom Mar 1, 2023
Merged
🐛 Fixed uploads of m4a files with audio/mp4 content type#16342daniellockyer merged 1 commit intoTryGhost:mainfrom
daniellockyer merged 1 commit intoTryGhost:mainfrom
Conversation
fixes TryGhost#16301 Previously, audio/x-m4a was allowed but not audio/mp4. This meant uploads of m4a files failed in some cases e.g. Firefox on Windows.
reupen
force-pushed
the
fix-firefox-m4a-uploads
branch
from
5f1bc69 to
e6dc32d
Compare
reupen
commented
Feb 27, 2023
| .set('Origin', config.get('url')) | ||
| .expect('Content-Type', /json/) | ||
| .field('ref', 'audio_file_mp4') | ||
| .attach('file', path.join(__dirname, '/../../utils/fixtures/media/sample.m4a'), {filename: 'audio-mp4.m4a', contentType: 'audio/mp4'}) |
Contributor
Author
There was a problem hiding this comment.
audio/mp4 is actually the default here, but I made sure that both content types are explicitly covered.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #16342 +/- ##
==========================================
+ Coverage 72.37% 72.39% +0.01%
==========================================
Files 1789 1789
Lines 114022 114010 -12
Branches 17187 17184 -3
==========================================
+ Hits 82529 82540 +11
+ Misses 30176 30152 -24
- Partials 1317 1318 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Thanks @reupen 🎉 This will be shipped in the next Ghost release 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16301
Previously, audio/x-m4a was allowed but not audio/mp4. This meant uploads of m4a files failed in some cases e.g. Firefox on Windows (as per the linked issue).
yarn test:allandyarn lint)