🐛 Allow administrators to change other users' passwords#10891
Merged
allouis merged 1 commit intoTryGhost:masterfrom Jul 15, 2019
Merged
🐛 Allow administrators to change other users' passwords#10891allouis merged 1 commit intoTryGhost:masterfrom
allouis merged 1 commit intoTryGhost:masterfrom
Conversation
closes TryGhost#10427 - Administrators don't know other users' passwords, but they should be able to change other users' password - Don't require oldPassword to be provided
vikaspotluri123
changed the title
allouis
added a commit
that referenced
this pull request
Jul 16, 2019
* master: (24 commits) Version bump to 2.25.7 Updated Ghost-Admin to 2.25.7 Update default 404 page Update dependency markdown-it to v9 💡 Bumped minimum node v8.x version to v8.10.0 Update dependency knex to v0.19.0 Update dependency brute-knex to v4 Update dependency intl-messageformat to v5 Update dependency probe-image-size to v4.1.1 🐛 Allowed administrators to change other users' passwords (#10891) 🐛 Fixed error message when get helper doesn't have API access (#10892) Update dependency intl-messageformat to v4.4.0 Fixed typo in readme (#10885) Replaced v1 for v4 uuids (#10871) Update dependency probe-image-size to v4.0.1 Update dependency mock-knex to v0.4.6 Update dependency markdown-it-footnote to v3.0.2 Update dependency lodash to v4.17.14 Update dependency gscan to v2.6.3 Update dependency ajv to v6.10.2 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10427
I've manually tested that Authors cannot change other users' passwords, but I'm not sure where the tests are for that; I'm not sure if I need to add any additional tests as well