Replaced i18n.t w/ tpl helper in LocalFileStorage

ErisDS · ErisDS · commit ca149f2c0e80 · 2021-09-30T17:50:41.000+01:00
refs: #13380 - this is a refactor we are looking to do everywhere - this commit is a reference for how to do the refactor: in small minimal pieces
diff --git a/core/server/adapters/storage/LocalFileStorage.js b/core/server/adapters/storage/LocalFileStorage.js
@@ -7,13 +7,19 @@ const path = require('path');
 const Promise = require('bluebird');
 const moment = require('moment');
 const config = require('../../../shared/config');
-const i18n = require('../../../shared/i18n');
+const tpl = require('@tryghost/tpl');
 const logging = require('@tryghost/logging');
 const errors = require('@tryghost/errors');
 const constants = require('@tryghost/constants');
 const urlUtils = require('../../../shared/url-utils');
 const StorageBase = require('ghost-storage-base');
 
+const messages = {
+    imageNotFound: 'Image not found',
+    imageNotFoundWithRef: 'Image not found: {img}',
+    cannotReadImage: 'Could not read image: {img}'
+};
+
 class LocalFileStore extends StorageBase {
     constructor() {
         super();
@@ -119,7 +125,7 @@ class LocalFileStore extends StorageBase {
                 if (err) {
                     if (err.statusCode === 404) {
                         return next(new errors.NotFoundError({
-                            message: i18n.t('errors.errors.imageNotFound'),
+                            message: tpl(messages.imageNotFound),
                             code: 'STATIC_FILE_NOT_FOUND',
                             property: err.path
                         }));
@@ -169,7 +175,7 @@ class LocalFileStore extends StorageBase {
                     if (err.code === 'ENOENT' || err.code === 'ENOTDIR') {
                         return reject(new errors.NotFoundError({
                             err: err,
-                            message: i18n.t('errors.errors.imageNotFoundWithRef', {img: options.path})
+                            message: tpl(messages.imageNotFoundWithRef, {img: options.path})
                         }));
                     }
 
@@ -183,7 +189,7 @@ class LocalFileStore extends StorageBase {
 
                     return reject(new errors.GhostError({
                         err: err,
-                        message: i18n.t('errors.errors.cannotReadImage', {img: options.path})
+                        message: tpl(messages.cannotReadImage, {img: options.path})
                     }));
                 }
 
