Repository navigation
feat: add mssql adapter - #29
Merged
Merged
Conversation
Truta446
added a commit
that referenced
this pull request
Aug 22, 2026
…terpolated N+1s Follow-up to #29. Three things the adapter was missing: - `parameterValues()` returned `[]` for a request with no `.input()` calls. A scope tells an N+1 apart from a statement that merely runs twice by watching the values vary, and falls back to the raw SQL only when the driver reports *no* parameters — so `[]` handed it a discriminator that was identical on every iteration. A loop building its SQL by interpolation, which is the code most likely to have an N+1 in it, was never reported. It now returns undefined when nothing was bound. - `Request.prototype.batch()` was not patched, so a T-SQL batch went unseen. - `PreparedStatement` was not patched. Executing one in a loop is an N+1 that costs less per iteration and is therefore easier to miss. The statement is captured at `prepare()` rather than read off an internal property, so a rename in the driver cannot silently break it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
What changed
Verification