Skip to content

[ACL-250]: Adds payouts in Poland#339

Merged
tl-luca-baggi merged 14 commits into
mainfrom
adds-payouts-pln
Mar 14, 2025
Merged

[ACL-250]: Adds payouts in Poland#339
tl-luca-baggi merged 14 commits into
mainfrom
adds-payouts-pln

Conversation

@dili91

@dili91 dili91 commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Description

  • Introduce support for PLN payouts (specifically, add support for NRB Account identifier type)
  • Update dependencies
  • Update Gradle version

Type of change

Please select multiple options if required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have updated the gradle.properties file with the new version
  • I have updated the CHANGELOG.md file with the details of the new versio
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the relevant documentation

Comment thread build.gradle
// JUnit test framework.
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter', version: '5.11.4'
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter', version: '5.12.0'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, tests tasks were failing with new Junit version

@tl-luca-baggi
tl-luca-baggi marked this pull request as ready for review March 6, 2025 16:28
@tl-luca-baggi
tl-luca-baggi requested review from a team as code owners March 6, 2025 16:28
SchemeSelection.instantPreferred().build()),
Arguments.of(
CurrencyCode.PLN,
AccountIdentifier.iban().iban("GB25CLRB04066800046876").build(),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use the NRB here because the merchant account generated on the console has a GB IBAN, so NRB validation fails on MAP side (more info in this Slack thread)

@tl-luca-baggi
tl-luca-baggi merged commit fa33887 into main Mar 14, 2025
@tl-luca-baggi
tl-luca-baggi deleted the adds-payouts-pln branch March 14, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants