test: launch rmdir with spawnSync

Trott · Trott · commit 2edb6045ebd2 · 2019-06-18T21:42:35.000-07:00
In the `common/tmpdir` module used for testing, `rmdir` on Windows
executes via `execSync()` which will fail if there is a space (or
perhaps other special characters?) in `pathname`. Use `spawnSync()`
instead so that args can be put into an array and escaping handled
automatically.
diff --git a/test/common/tmpdir.js b/test/common/tmpdir.js
@@ -1,7 +1,7 @@
 /* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
-const { execSync } = require('child_process');
+const { spawnSync } = require('child_process');
 const fs = require('fs');
 const path = require('path');
 const { debuglog } = require('util');
@@ -28,7 +28,7 @@ function rimrafSync(pathname, { spawn = true } = {}) {
   if (spawn && process.platform === 'win32' && st.isDirectory()) {
     try {
       // Try `rmdir` first.
-      execSync(`rmdir /q /s ${pathname}`, { timout: 1000 });
+      spawnSync('rmdir', ['/q', '/s', pathname], { timout: 1000 });
     } catch (e) {
       // Attempt failed. Log and carry on.
       debug(e);
