Repository navigation
fix(client): refresh the Markdown preview on note switch - #11895
Merged
Merged
Conversation
…iumNext#11894) Once the editor of a preview-only Markdown note has been shown, it stays mounted but hidden and feeds the preview. `setText()` replaces the state of a hidden editor with `setState()`, which fires no update listener, so `onContentChanged` never ran when another note's content was loaded and the preview kept the previous note's HTML. `EditableCode` now calls `onContentChanged` itself after loading the content.
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Signed-off-by: drakeo338 <[email protected]>
A visible editor's `setText()` dispatches a transaction, and the CodeMirror update listener in `EditableCode` already passes the new content to `onContentChanged`. Calling it again after every load made `SvgSplitEditor` render each Mermaid or other diagram note twice on open. Only a hidden editor, which `setText()` fills through `setState()` without an update, needs the explicit call, so it now runs only when the editor's `offsetParent` is `null`, the same test `setText()` uses. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The notes come from `buildNote()` instead of a hand-rolled object cast to `any`, and `renderInto()` tears the container down, so the spec needs no `afterEach` cleanup of its own. jsdom has no layout, so the first test loads into an editor that counts as hidden; it fails at the first load without the fix. A second test pins `offsetParent` to make the editor visible and checks that a load reports exactly once. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
|
🖥️ App preview is ready! 🔗 Preview URL: https://pr-11895.trilium-app.pages.dev ✅ All checks passed This preview will be updated automatically with new commits. |
Bundle ReportChanges will increase total bundle size by 38 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: standalone-esmAssets Changed:
view changes for bundle: client-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11894.
In a Markdown note's preview mode, switching to another Markdown note updated the title but left the previous note's rendered content. The preview is fed by the editor's content-changed callback, and the load path that fills the editor with the new note's text never called it, so the preview kept the old content. The change calls that callback after the text is set. A new test in
Code.spec.tsxfails on the unfixed source and passes with the fix.