Multiple fixes for compilation errors and warnings#20
Merged
rossphilipson merged 2 commits intoTrenchBoot:masterfrom Jul 27, 2020
Merged
Multiple fixes for compilation errors and warnings#20rossphilipson merged 2 commits intoTrenchBoot:masterfrom
rossphilipson merged 2 commits intoTrenchBoot:masterfrom
Conversation
* unused static functions - marked with '__attribute__ ((unused))' * unused variables - removed * cast to pointer from an integer of different size - changed to uintptr_t * lack of parentheses in macro - added Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
dpsmith
approved these changes
Jul 27, 2020
rossphilipson
approved these changes
Jul 27, 2020
Collaborator
rossphilipson
left a comment
rossphilipson
left a comment
There was a problem hiding this comment.
This looks good to me
Reviewed-by: Ross Philipson [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krystian Hebel [email protected]