Merged
Conversation
krystian-hebel
force-pushed
the
add_sha256
branch
2 times, most recently
from
4e6d107 to
3599a7a
Compare
krystian-hebel
force-pushed
the
add_sha256
branch
from
183a71c to
a7c9149
Compare
dpsmith
approved these changes
Jan 28, 2020
| @@ -1002,20 +1002,25 @@ struct tpm *enable_tpm(void) | |||
|
|
|||
| void tpm_request_locality(struct tpm *t, u8 l) | |||
Collaborator
There was a problem hiding this comment.
This function is declared as void but you are returning a value?
andyhhp
reviewed
Jan 28, 2020
include/sha256.h
Outdated
|
|
||
| void sha256sum(u8 *hash, void *data, u32 len); | ||
|
|
||
| #endif /* SHA256_H */ No newline at end of file |
Signed-off-by: Michał Żygowski <[email protected]> Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]> Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Stack overflows by ~64 bytes. Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
krystian-hebel
force-pushed
the
add_sha256
branch
from
a7c9149 to
d3d9b95
Compare
dpsmith
approved these changes
Feb 17, 2020
Collaborator
|
I'll do a followup to consolidate the byteswap functionality. This series' implementation of cpu_to_be64 looks to generate correct code, but does it longhand rather than using the |
andyhhp
approved these changes
Feb 17, 2020
rossphilipson
approved these changes
Feb 17, 2020
Collaborator
rossphilipson
left a comment
rossphilipson
left a comment
There was a problem hiding this comment.
Reviewed-by: Ross Philipson [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.