Skip to content

test(nodes): move publish_findings node_test.py into tests/ tree#965

Merged
muddlebee merged 1 commit intoTracer-Cloud:mainfrom
Lozsku:issue/903-move-publish-findings-node-test
Apr 27, 2026
Merged

test(nodes): move publish_findings node_test.py into tests/ tree#965
muddlebee merged 1 commit intoTracer-Cloud:mainfrom
Lozsku:issue/903-move-publish-findings-node-test

Conversation

@Lozsku
Copy link
Copy Markdown
Contributor

@Lozsku Lozsku commented Apr 26, 2026

Summary

  • Moves app/nodes/publish_findings/node_test.pytests/nodes/publish_findings/test_node.py, following the project convention that all tests live under tests/.
  • Adds missing tests/nodes/publish_findings/__init__.py so pytest discovers the package.
  • No logic changes — pure file rename + empty init file.

Test plan

  • pytest tests/nodes/publish_findings/test_node.py passes
  • app/nodes/publish_findings/node_test.py no longer exists

Closes #903

Adds missing __init__.py to tests/nodes/publish_findings/ so pytest
discovers the package, then renames node_test.py to follow the
test_*.py convention expected by the test runner.

Closes Tracer-Cloud#903
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 26, 2026

Greptile Summary

This PR moves app/nodes/publish_findings/node_test.py to tests/nodes/publish_findings/test_node.py and adds the required __init__.py, with zero logic changes. Both co-located and tests/-tree placements are valid per the project's testing conventions (testing.mdc), so this is a valid housekeeping move.

Confidence Score: 5/5

Safe to merge — pure file rename with no logic changes and correct package init added.

No logic changes at all; the only diff is a file move and an empty init.py. The new location is consistent with sibling test packages and the init.py matches the pattern used by tests/nodes/investigate/, tests/nodes/plan_actions/, etc. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
tests/nodes/publish_findings/test_node.py Pure rename from app/nodes/publish_findings/node_test.py; test logic is unchanged and covers _build_mr_note and GitLab MR write-back paths
tests/nodes/publish_findings/init.py Empty init file added to make the new test package discoverable by pytest, consistent with sibling packages

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["app/nodes/publish_findings/node_test.py\n(removed)"] -- renamed --> B["tests/nodes/publish_findings/test_node.py\n(added)"]
    C["tests/nodes/publish_findings/__init__.py\n(new, empty)"] -- enables --> D["pytest discovery"]
    B -- discovered by --> D
Loading

Reviews (1): Last reviewed commit: "test(nodes): move publish_findings node_..." | Re-trigger Greptile

@hamzzaaamalik
Copy link
Copy Markdown
Collaborator

hamzzaaamalik commented Apr 27, 2026

Verified locally:

  • app/nodes/publish_findings/node_test.py ran with 7/7 passing on main
  • After the move + new init.py, tests/nodes/publish_findings/test_node.py still runs 7/7
  • No other code imports from the old location, so the rename is safe

Follows the AGENTS.md convention ("tests should be in tests/, never in app/"). FYI there are still 4 other inline *_test.py files in app/ (cli/deploy_test.py, integrations/gitlab_test.py, nodes/plan_actions/detect_sources_test.py, tools/utils/log_compaction_test.py) for whoever picks up the rest of issue #903.

LGTM.

@VaibhavUpreti

@muddlebee

@muddlebee
Copy link
Copy Markdown
Collaborator

@hamzzaaamalik sorry wrong tag. This looks good. Merging.

@muddlebee muddlebee merged commit 6573730 into Tracer-Cloud:main Apr 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move app/nodes/publish_findings/node_test.py into tests/nodes/publish_findings/

3 participants