test(nodes): move publish_findings node_test.py into tests/ tree#965
Conversation
Adds missing __init__.py to tests/nodes/publish_findings/ so pytest discovers the package, then renames node_test.py to follow the test_*.py convention expected by the test runner. Closes Tracer-Cloud#903
Greptile SummaryThis PR moves Confidence Score: 5/5Safe to merge — pure file rename with no logic changes and correct package init added. No logic changes at all; the only diff is a file move and an empty init.py. The new location is consistent with sibling test packages and the init.py matches the pattern used by tests/nodes/investigate/, tests/nodes/plan_actions/, etc. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["app/nodes/publish_findings/node_test.py\n(removed)"] -- renamed --> B["tests/nodes/publish_findings/test_node.py\n(added)"]
C["tests/nodes/publish_findings/__init__.py\n(new, empty)"] -- enables --> D["pytest discovery"]
B -- discovered by --> D
Reviews (1): Last reviewed commit: "test(nodes): move publish_findings node_..." | Re-trigger Greptile |
|
Verified locally:
Follows the AGENTS.md convention ("tests should be in tests/, never in app/"). FYI there are still 4 other inline *_test.py files in app/ (cli/deploy_test.py, integrations/gitlab_test.py, nodes/plan_actions/detect_sources_test.py, tools/utils/log_compaction_test.py) for whoever picks up the rest of issue #903. LGTM. |
|
@hamzzaaamalik sorry wrong tag. This looks good. Merging. |
Summary
app/nodes/publish_findings/node_test.py→tests/nodes/publish_findings/test_node.py, following the project convention that all tests live undertests/.tests/nodes/publish_findings/__init__.pyso pytest discovers the package.Test plan
pytest tests/nodes/publish_findings/test_node.pypassesapp/nodes/publish_findings/node_test.pyno longer existsCloses #903