Skip to content

test(tools): move log_compaction_test.py into tests/ tree#964

Merged
VaibhavUpreti merged 1 commit intoTracer-Cloud:mainfrom
Lozsku:issue/904-move-log-compaction-test
Apr 27, 2026
Merged

test(tools): move log_compaction_test.py into tests/ tree#964
VaibhavUpreti merged 1 commit intoTracer-Cloud:mainfrom
Lozsku:issue/904-move-log-compaction-test

Conversation

@Lozsku
Copy link
Copy Markdown
Contributor

@Lozsku Lozsku commented Apr 26, 2026

Summary

  • Moves app/tools/utils/log_compaction_test.py into tests/tools/test_log_compaction.py, following the project convention that all tests live under tests/ (AGENTS.md: "If adding new tests → always place them in tests/, never in app/").
  • No logic changes — pure file rename; git detects it as a rename.

Test plan

  • pytest tests/tools/test_log_compaction.py passes (all cases green locally)
  • app/tools/utils/log_compaction_test.py no longer exists

Closes #904

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 26, 2026

Greptile Summary

This PR is a pure rename — app/tools/utils/log_compaction_test.py is moved to tests/tools/test_log_compaction.py with zero content changes. The new location is consistent with every other test file already present in tests/tools/ and satisfies the AGENTS.md rule ("If adding new tests → always place them in tests/, never in app/").

Confidence Score: 5/5

Safe to merge — pure file rename with no logic changes.

No code changes whatsoever; the move targets the correct directory, follows naming conventions (test_*.py), and the destination already has init.py and conftest.py in place for pytest discovery.

No files require special attention.

Important Files Changed

Filename Overview
tests/tools/test_log_compaction.py Pure rename of app/tools/utils/log_compaction_test.py → tests/tools/test_log_compaction.py; no logic changes, file lands correctly alongside peer test files in tests/tools/.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["app/tools/utils/log_compaction_test.py\n(deleted)"] -->|"git rename\n(100% similarity)"| B["tests/tools/test_log_compaction.py\n(new location)"]
    B --> C["pytest auto-discovery\nvia tests/tools/__init__.py"]
    B --> D["Imports unchanged:\napp.tools.utils.log_compaction"]
Loading

Reviews (1): Last reviewed commit: "test(tools): move log_compaction_test.py..." | Re-trigger Greptile

Copy link
Copy Markdown
Member

@VaibhavUpreti VaibhavUpreti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks a lot for taking this up @Lozsku ! Welcome to the OpenSRE community

@VaibhavUpreti VaibhavUpreti merged commit 3a61961 into Tracer-Cloud:main Apr 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move app/tools/utils/log_compaction_test.py into the test tree

2 participants