refactor: move gitlab integration tests to tests/integrations (#901)#917
Conversation
Greptile SummaryThis PR moves The PR description body still contains the unfilled template placeholder Confidence Score: 5/5Safe to merge — pure file rename with no code changes and no functional risk. The only change is a file move. All 40 tests are structurally identical to before, imports resolve correctly from the new location, and the placement matches the project's testing conventions. The only open item is the unfilled PR description placeholder, which is a process nit and does not affect code correctness. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["app/integrations/gitlab_test.py\n(old location)"] -->|"git mv"| B["tests/integrations/test_gitlab.py\n(new location)"]
B --> C["pytest auto-discovery\nvia test_*.py naming"]
C --> D["40 tests collected & passing"]
style A fill:#f9a,stroke:#c77,stroke-dasharray:5
style B fill:#9f9,stroke:#696
style D fill:#9cf,stroke:#36a
Reviews (1): Last reviewed commit: "refactor: move gitlab integration tests ..." | Re-trigger Greptile |
|
Hi! Just a heads up, the CI pipeline failed, but it looks like an unrelated failure on main. My GitLab tests passed, but tests/nodes/plan_actions/test_node_plan_actions.py is failing with an AttributeError on a mock missing model_copy. Let me know if you need me to rebase once main is patched! |
|
@sirohikartik pls check CI, seems to be related to your change?? check the logs https://github.com/Tracer-Cloud/opensre/actions/runs/24923327480/job/72988859074?pr=917 |
|
CI is green in main |
9b76eb9 to
71ed8a2
Compare
|
Hey @muddlebee , I just synced the branch with the latest main. I think this is ready to get merged. Thanks! |
|
@sirohikartik thanks ✨ |
Fixes #901
Describe the changes you have made in this PR -
This PR fulfills the acceptance criteria by relocating the GitLab integration test suite to sit alongside the rest of the integration tests.
app/integrations/gitlab_test.pytotests/integrations/test_gitlab.pyusinggit mvto preserve file history.Screenshots of the UI changes (If any) -
N/A - backend refactoring only.
Code Understanding and AI Usage
Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?
Explain your implementation approach:
app/directory and into thetests/integrations/directory to match the repository's standard structure.git mvto move the file and renamed it totest_gitlab.pyso thatpytestauto-discovers it. The suite was run post-move to ensure 100% test passing and coverage retention.Checklist before requesting a review