fix(release-announcements): include role mention in Discord release announcement#1310
Merged
muddlebee merged 1 commit intoTracer-Cloud:mainfrom May 5, 2026
Merged
fix(release-announcements): include role mention in Discord release announcement#1310muddlebee merged 1 commit intoTracer-Cloud:mainfrom
muddlebee merged 1 commit intoTracer-Cloud:mainfrom
Conversation
Contributor
Greptile Summary
Confidence Score: 5/5Safe to merge — change is minimal, well-guarded, and handles the absent-secret case correctly. No logic errors, security concerns, or breaking changes found. The role mention is optional, properly guarded with a -n check and ${VAR:-} expansion, and the newline-terminated mention is safely encoded through jq's --arg flag. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub (release published)
participant WF as release-announcements.yml
participant DC as Discord Webhook
GH->>WF: Trigger on release published
WF->>WF: Check DISCORD_WEBHOOK_URL set?
alt webhook not set
WF-->>WF: Skip (exit 0)
else webhook set
WF->>WF: Check DISCORD_RELEASES_ROLE_ID set?
alt role ID set
WF->>WF: role_mention = "<@&ROLE_ID>\n"
else not set
WF->>WF: role_mention = ""
end
WF->>WF: Build payload via jq (mention + message body)
WF->>DC: POST JSON payload
DC-->>WF: 2xx OK
end
Reviews (1): Last reviewed commit: "fix(release-announcements): include role..." | Re-trigger Greptile |
Contributor
|
😤 @Devesh36 said "I will fix this" and then actually fixed it. Legendary behavior. 👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request updates the release announcement workflow to optionally mention a Discord role when sending release notifications. The workflow now supports including a role mention in the announcement message if a role ID is provided.
Discord role mention support:
.github/workflows/release-announcements.yml: Added theDISCORD_RELEASES_ROLE_IDenvironment variable to the workflow, allowing the role ID to be passed from repository secrets..github/workflows/release-announcements.yml: Updated the announcement script to construct arole_mentionstring if the role ID is set, and prepend it to the Discord message content. [1] [2]