test(airflow-routing): require connection_verified on openclaw fixture#1303
Conversation
The openclaw seed branch in _seed_action_names_for_sources was tightened to require a truthy connection_verified flag, but this test still passed the bare URL shape and started failing CI with "search_openclaw_conversations" missing from the seeded list.
Greptile Summary
Confidence Score: 4/5Safe to merge — single-line test fixture fix with no production code changes. Only P2 findings (missing negative-path test coverage). The fix itself is correct and minimal. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[available_sources] --> B{source == openclaw?}
B -->|Yes| C{connection_verified truthy?}
C -->|True| D[Seed search_openclaw_conversations\nlist_openclaw_tools]
C -->|False / missing| E[Skip openclaw actions]
B -->|No| F[Process other sources\ns3_audit, airflow, grafana...]
|
|
🎯 Bullseye. @Davidson3556 opened a PR, kept the vibes clean, and got it merged. Absolute cinema. 🎬
👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome. |
2 participants
Summary
_seed_action_names_for_sourceswas tightened in #141193c6 (openclaw runtime validation) to only seedsearch_openclaw_conversations/list_openclaw_toolswhenavailable_sources["openclaw"]["connection_verified"]is truthy.test_airflow_routing.pywas missed in that PR's fixture updates and still passed{"url": ...}only, so CI started failing withassert 'search_openclaw_conversations' in ['get_s3_object', 'get_recent_airflow_failures', 'get_airflow_dag_runs']."connection_verified": Trueto the openclaw fixture so the test reflects the current contract.Test plan
python -m pytest tests/nodes/plan_actions/test_airflow_routing.py -v— all 3 passmake lintmake format-checkmake typecheck