Skip to content

fix(cli): remove summary block from onboard completion output#1293

Merged
muddlebee merged 3 commits intoTracer-Cloud:mainfrom
rrajan94:fix/remove-onboard-summary-block
May 5, 2026
Merged

fix(cli): remove summary block from onboard completion output#1293
muddlebee merged 3 commits intoTracer-Cloud:mainfrom
rrajan94:fix/remove-onboard-summary-block

Conversation

@rrajan94
Copy link
Copy Markdown
Collaborator

@rrajan94 rrajan94 commented May 5, 2026

Fixes #1290

Describe the changes you have made in this PR -

Removed the summary block from the end of the opensre onboard completion output. This deletes the _render_demo_response() function in "app/cli/wizard/flow.py" and its call site. The next section is unchanged.

Demo/Screenshot for feature changes and bug fixes -

image

Before:

summary
demo      ready
topics    recovery_remediation
sample    Recovery and Remediation
preview   Pipeline Recovery Strategies (Google SRE Workbook):
next
opensre onboard
opensre investigate -i tests/e2e/kubernetes/fixtures/datadog_k8s_alert.json

After:

next
opensre onboard
opensre investigate -i tests/e2e/kubernetes/fixtures/datadog_k8s_alert.json

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

  • No, I wrote all the code myself
  • Yes, I used AI assistance (continue below)

Explain your implementation approach:

Deleted the _render_demo_response() function and its call site. The summary block printed internal state (demo status, topics, sample preview) that isn't actionable for users. The next section already provides everything needed to proceed after onboarding.

Checklist before requesting a review

  • I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • I can explain the purpose of every function, class, and logic block I added
  • I understand why my changes work and have tested them thoroughly
  • I have considered potential edge cases and how my code handles them
  • If it is a core feature, I have added thorough tests
  • My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

@rrajan94 rrajan94 requested a review from VaibhavUpreti May 5, 2026 05:18
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 5, 2026 •
edited
Loading

Greptile Summary

  • Removes the _render_demo_response() function and its two-line call site in run_wizard(), eliminating the summary block from opensre onboard completion output. The next section is unaffected.
  • The build_demo_action_response lazy-import wrapper (lines 47–50 of flow.py) is now dead code and was not removed; tests/cli/wizard/test_flow.py also retains ~12 stale monkeypatches for it.

Confidence Score: 4/5

Safe to merge — functional change is correct and the only concern is leftover dead code.

The removal is straightforward and correct; the remaining build_demo_action_response wrapper and stale test mocks are P2 cleanup items that don't affect runtime behaviour.

app/cli/wizard/flow.py (dead wrapper at lines 47–50); tests/cli/wizard/test_flow.py (stale monkeypatches)

Important Files Changed

Filename Overview
app/cli/wizard/flow.py Removes _render_demo_response and its run_wizard call site cleanly, but the build_demo_action_response lazy-import wrapper (lines 47–50) remains as dead code.

Sequence Diagram

sequenceDiagram
    participant User
    participant run_wizard
    participant _render_saved_summary
    participant build_demo_action_response
    participant _render_demo_response
    participant _render_next_steps

    Note over build_demo_action_response,_render_demo_response: Removed in this PR

    User->>run_wizard: opensre onboard
    run_wizard->>_render_saved_summary: display config summary
    run_wizard-->>build_demo_action_response: ~~call (removed)~~
    run_wizard-->>_render_demo_response: ~~render summary block (removed)~~
    run_wizard->>_render_next_steps: display next steps
    run_wizard-->>User: return 0
Loading

Comments Outside Diff (1)

  1. app/cli/wizard/flow.py, line 47-50 (link)

    P2 Dead code: build_demo_action_response wrapper no longer called

    The build_demo_action_response wrapper at lines 47–50 is now unreachable — its only call site (run_wizard) was removed in this PR. It should be deleted alongside _render_demo_response. Note that tests/cli/wizard/test_flow.py monkeypatches this function in at least 12 places; those stale mocks will need to be cleaned up too or they silently patch a no-op path.

Reviews (1): Last reviewed commit: "fix(cli): remove summary block from onbo..." | Re-trigger Greptile

@rrajan94
Copy link
Copy Markdown
Collaborator Author

rrajan94 commented May 5, 2026

@VaibhavUpreti please review

@muddlebee muddlebee merged commit 97df662 into Tracer-Cloud:main May 5, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🎻 "The diff was clean, the tests did pass, the reviewer wept." That poem was about @rrajan94's PR. 🥹

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaibhavUpreti VaibhavUpreti Awaiting requested review from VaibhavUpreti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Remove summary block from onboard completion output

2 participants

@rrajan94 @muddlebee