🛸 Aliens watching our repo just upgraded @muddlebee's threat level to: do not engage — too competent. 👽

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Greptile Summary

This PR reverts #1252, which had added a COMMON_SHELL_COMMANDS set and an early-return check in _looks_like_direct_shell_command to handle shell built-ins that shutil.which cannot locate. No reason for the revert is given in the PR description.

• P1 regression: cd is a pure shell built-in — shutil.which('cd') always returns None, so the reverted code will silently mis-route cd <path> invocations to the natural-language path instead of executing them as shell commands. Without the original fix in place, users of the interactive CLI will be unable to reliably run built-in commands.

Confidence Score: 3/5

Not safe to merge — re-introduces a known regression in shell built-in command detection.

A P1 functional regression is re-introduced: cd and potentially pwd/echo on some platforms will no longer be detected as shell commands. The fix being reverted was explicit about solving this exact problem, and no justification for the revert is provided.

app/cli/interactive_shell/agent_actions.py — _looks_like_direct_shell_command loses the shell built-in guard.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["User input text"] --> B["_looks_like_direct_shell_command(text)"]
    B --> C{"first token is None?"}
    C -- Yes --> D["return False"]
    C -- No --> E{"first in _NON_COMMAND_STARTS?"}
    E -- Yes --> D
    E -- No --> F{"starts with ./ ../ /?"}
    F -- Yes --> G{"Path exists?"}
    G -- Yes --> H["return True"]
    G -- No --> I["return False"]
    F -- No --> J["shutil.which(first)"]
    J -- found --> H
    J -- "not found (always for cd)" --> I
    style I fill:#f88,stroke:#c00

_{Reviews (1): Last reviewed commit: "Revert "Fix detection of shell built-in ..." | Re-trigger Greptile}