Greptile Summary

Replaces the previous heuristic auth detection (env var → credentials file → macOS Keychain guess) with a proper claude auth status subprocess probe in _probe_cli_auth, resolving the macOS Keychain dead-end. Error semantics are now correct throughout — None for indeterminate state, False only when the CLI explicitly reports unauthenticated — and the no-binary fallback path retains the original resolution order with ANTHROPIC_API_KEY checked first.

Confidence Score: 5/5

Safe to merge; all findings are P2 style/consistency nits.

No P0 or P1 issues found. The two P2 findings are stale claude login references in auth_hint and the module docstring — they don't affect runtime behavior. Logic, error handling, and test coverage are all correct.

No files require special attention beyond the two minor stale-string nits in claude_code.py.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[detect] --> B[_resolve_binary]
    B -->|no binary| C[CLIProbe installed=False]
    B -->|binary found| D[_probe_binary]
    D --> E[claude --version]
    E -->|error / non-zero| F[CLIProbe installed=False]
    E -->|exit 0| G[_classify_claude_code_auth binary_path]
    G -->|binary_path set| H[_probe_cli_auth]
    G -->|no binary_path + API key| I[True: ANTHROPIC_API_KEY]
    G -->|no binary_path + creds file| J[True: credentials.json]
    G -->|no binary_path + macOS| K[None: Keychain unclear]
    G -->|no binary_path + Linux/Win| L[False: not authenticated]
    H --> M[claude auth status]
    M -->|TimeoutExpired / OSError| N[None: probe failed]
    M -->|non-zero exit| O[None: command failed]
    M -->|exit 0 + JSON loggedIn=false| P[False: not authenticated]
    M -->|exit 0 + JSON loggedIn=true| Q[True: subscription or API key]
    M -->|exit 0 + non-JSON| R[True: Claude CLI legacy]

_{Reviews (4): Last reviewed commit: "fix: return None for timeout and OSError..." | Re-trigger Greptile}

@greptileai review

@greptileai review

@greptileai review

🌊 Merged. @devankitjuneja is now permanently woven into git history. No take-backs. 😄

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.