test: consolidate remote-runtime tests under tests/remote/ (#872) by Davidson3556 · Pull Request #1215 · Tracer-Cloud/opensre

Davidson3556 · 2026-05-02T14:13:40Z

Fixes #872

Describe the changes you have made in this PR -

Consolidates the remote-runtime tests into a single canonical home. Before this change, tests for app/remote/* were split between tests/remote/ and tests/app/remote/, which made the coverage map confusing.

What this PR does:

Moves all 7 test modules from tests/app/remote/ into tests/remote/ (100% identical renames, no content changes)
Deletes the now-empty tests/app/remote/__init__.py so the duplicate package is gone
Leaves imports and pytest collection untouched — no source code or config changes were needed

Files moved:

test_client.py
test_reasoning.py
test_renderer.py
test_server.py
test_stream.py
test_system_metrics.py
test_vercel_poller.py

Demo/Screenshot for feature changes and bug fixes -

No naming collisions, no duplicate test modules, no stale imports referencing the old path.

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

No, I wrote all the code myself
Yes, I used AI assistance (continue below)

If you used AI assistance:

I have reviewed every single line of the AI-generated code
I can explain the purpose and logic of each function/component I added
I have tested edge cases and understand how the code handles them
I have modified the AI output to follow this project's coding standards and conventions

Explain your implementation approach:

The problem: the repo had two parallel homes for remote-runtime tests — tests/remote/ and tests/app/remote/. This made it unclear where new tests for app/remote/* should live and made the coverage map harder to read.

I considered two approaches:

Pick tests/app/remote/ as the canonical home (mirrors the app/remote/ source layout)
Pick tests/remote/ as the canonical home (matches the existing convention used by other folders like tests/services/, tests/nodes/, tests/integrations/, etc., which are flat under tests/)

I chose option 2 because every other capability boundary in tests/ is flat, not mirrored — tests/services/ (not tests/app/services/), tests/nodes/ (not tests/app/nodes/), and so on. Keeping remote tests flat under tests/remote/ matches the existing convention documented in AGENTS.md, and tests/remote/ already had more files than tests/app/remote/, so moving the smaller set was less churn.

There were no functions or classes added — this is a pure file-move refactor. Before moving, I checked that none of the 7 filenames being moved already existed in tests/remote/ (no collisions) and that no code referenced the old tests/app/remote/ path. After moving, I confirmed that tests/remote/ still collects 247 tests and the full suite still collects 4582 tests cleanly.

Checklist before requesting a review

I have added proper PR title and linked to the issue
I have performed a self-review of my code
I can explain the purpose of every function, class, and logic block I added
I understand why my changes work and have tested them thoroughly
I have considered potential edge cases and how my code handles them
If it is a core feature, I have added thorough tests
My code follows the project's style guidelines and conventions

Terminal output proving collection still works after the move:

…oud#872) Move the seven test modules under tests/app/remote/ into the canonical tests/remote/ home and drop the now-empty tests/app/remote/ package, so remote-runtime coverage lives in one obvious place. No naming collisions, no cross-test imports, and no duplicate coverage; pytest collects 247 tests in tests/remote/ and the full suite collects 4582 tests cleanly.

greptile-apps · 2026-05-02T14:15:08Z

Greptile Summary

This PR consolidates 7 test modules for app/remote/* from tests/app/remote/ into tests/remote/, deletes the now-empty tests/app/remote/__init__.py, and makes no content changes to any test file. All renames are 100% identical moves, tests/remote/__init__.py already exists, and imports remain unchanged.

Confidence Score: 5/5

Safe to merge — pure file renames with no content changes and no risk of broken collection.

All 7 files are 100%-identical renames; no logic, imports, or config was modified. tests/remote/init.py already existed pre-PR, so pytest package discovery is unaffected. The now-empty tests/app/remote/ directory is cleanly removed.

No files require special attention.

Important Files Changed

Filename	Overview
tests/app/remote/init.py	Empty package init file deleted — correctly removes the now-defunct duplicate package.
tests/remote/test_client.py	Renamed from tests/app/remote/test_client.py with no content changes; imports and test logic are intact.
tests/remote/test_server.py	Renamed from tests/app/remote/test_server.py with no content changes; all app.remote.server imports remain valid.
tests/remote/test_reasoning.py	Renamed from tests/app/remote/test_reasoning.py with no content changes.
tests/remote/test_renderer.py	Renamed from tests/app/remote/test_renderer.py with no content changes.
tests/remote/test_stream.py	Renamed from tests/app/remote/test_stream.py with no content changes.
tests/remote/test_system_metrics.py	Renamed from tests/app/remote/test_system_metrics.py with no content changes.
tests/remote/test_vercel_poller.py	Renamed from tests/app/remote/test_vercel_poller.py with no content changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[tests/app/remote/] -->|renamed 7 modules| B[tests/remote/]
    A -->|deleted| C[__init__.py ❌]
    B --> D[test_client.py]
    B --> E[test_reasoning.py]
    B --> F[test_renderer.py]
    B --> G[test_server.py]
    B --> H[test_stream.py]
    B --> I[test_system_metrics.py]
    B --> J[test_vercel_poller.py]
    B --> K[__init__.py ✅ pre-existing]

_{Reviews (1): Last reviewed commit: "test: consolidate remote-runtime tests u..." | Re-trigger Greptile}

Davidson3556 · 2026-05-02T14:23:50Z

@rrajan94 @davincios @muddlebee @VaibhavUpreti kindly review

muddlebee · 2026-05-02T14:51:55Z

LGTM. I will wait for additional ci checks, just enabled for windows

muddlebee · 2026-05-02T15:03:33Z

@Davidson3556 windows CI is failing pls check

muddlebee · 2026-05-02T15:04:07Z

Davidson3556 · 2026-05-02T16:20:29Z

Thanks , I checked, the failures are in tests/cli/interactive_shell/test_loop.py (added in #1167), not in any file this PR touches. They're caused by prompt_toolkit requiring a real Windows console buffer, which GitHub's windows-latest runner doesn't provide; the Ubuntu test job passes. The Windows jobs are also marked continue-on-error: true. Happy to open a separate PR to skip those tests on Windows if helpful.
@muddlebee

muddlebee · 2026-05-02T16:30:38Z

Sure @Davidson3556 let's fix the CI. Meanwhile I will merge this

github-actions · 2026-05-02T16:30:58Z

🐸 Rebase? Handled. Conflicts? Squashed. CI? Vibing. @Davidson3556 touched the untouchable and lived. 🫡

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Davidson3556 · 2026-05-02T16:32:37Z

sure I will do that now. thank you

muddlebee added the ci:windows label May 2, 2026

muddlebee merged commit bedcf25 into Tracer-Cloud:main May 2, 2026
12 of 13 checks passed

This was referenced May 2, 2026

test(cli): use dummy app session in prompt-session tests so they pass… #1224

Merged

Looking for Maintainers – $300-$500/month Symbolic Sponsorship #344

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: consolidate remote-runtime tests under tests/remote/ (#872)#1215

test: consolidate remote-runtime tests under tests/remote/ (#872)#1215
muddlebee merged 1 commit intoTracer-Cloud:mainfrom
Davidson3556:chore/consolidate-remote-tests-872

Davidson3556 commented May 2, 2026

Uh oh!

greptile-apps Bot commented May 2, 2026

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Davidson3556 commented May 2, 2026

Describe the changes you have made in this PR -

Demo/Screenshot for feature changes and bug fixes -

Code Understanding and AI Usage

Checklist before requesting a review

Uh oh!

greptile-apps Bot commented May 2, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

Davidson3556 commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants