🎉 MERGED! @muddlebee just shipped something. The diff gods are pleased. 🙌

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Greptile Summary

This PR reverts #1189, removing two test functions (test_analytics_disabled_via_opensre_env_var and test_analytics_disabled_via_do_not_track_env_var) from tests/analytics/test_provider.py. The production implementation of the opt-out feature (_is_opted_out() in app/analytics/provider.py) remains intact, so the revert leaves the env-var-based analytics opt-out logic without any test coverage.

Confidence Score: 4/5

Safe to merge — pure test deletion with no production code changes, but removes coverage for an active feature.

Only P2 findings present; no production logic is altered. The sole concern is loss of test coverage for the opt-out env var paths that remain in the codebase.

tests/analytics/test_provider.py — the removed tests should be re-added in a follow-up PR to cover _is_opted_out() in app/analytics/provider.py.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Analytics.__init__()"] --> B["_is_opted_out()"]
    B --> C{"OPENSRE_ANALYTICS_DISABLED == '1'\nor DO_NOT_TRACK == '1'"}
    C -- Yes --> D["self._disabled = True"]
    C -- No --> E["self._disabled = False"]
    D --> F["capture() → early return (no-op)"]
    E --> G["capture() → enqueue event"]

_{Reviews (1): Last reviewed commit: "Revert "feat: Add analytics opt-out envi..." | Re-trigger Greptile}