test: added direct unit tests for app/cli/local_llm/hardware.py by umeraamir09 · Pull Request #1187 · Tracer-Cloud/opensre

umeraamir09 · 2026-05-01T17:32:36Z

Fixes #905

Describe the changes you have made in this PR -

Add direct unit tests for _get_total_ram_gb(), _get_available_ram_gb(), and detect_hardware() in app/cli/local_llm/hardware.py.

24 tests across Linux /proc/meminfo parsing, macOS sysctl parsing, and unknown platform fallbacks
Covers success paths, command/file-read failures, parse errors, missing keys, and non-integer output
detect_hardware() tests verify profile assembly: Apple Silicon, macOS Intel, Linux with/without NVIDIA, and fallback RAM propagation
NVIDIA detection via shutil.which("nvidia-smi") explicitly verified
All tests are fully mocked with sys.platform patches — zero host OS dependency

Demo/Screenshot for feature changes and bug fixes -

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

No, I wrote all the code myself
Yes, I used AI assistance (continue below)
If you used AI assistance:
I have reviewed every single line of the AI-generated code
I can explain the purpose and logic of each function/component I added
I have tested edge cases and understand how the code handles them
I have modified the AI output to follow this project's coding standards and conventions
Explain your implementation approach:
This test covers the three hardware detection functions in isolation by patching sys.platform, subprocess.check_output, builtins.open, platform.machine, and shutil.which. Each test class focuses on one function on one platform (Linux, macOS, or unknown), with helpers like _call() and _detect() reducing boilerplate. The detect_hardware() tests mock the lower-level RAM functions to verify profile assembly logic independently. Fallback behavior (8 GB total, total * 0.5 available) is tested on every failure mode — file I/O errors, parse failures, missing keys, subprocess failures, and unrecognized platforms.

Checklist before requesting a review

I have added proper PR title and linked to the issue
I have performed a self-review of my code
I can explain the purpose of every function, class, and logic block I added
I understand why my changes work and have tested them thoroughly
I have considered potential edge cases and how my code handles them
If it is a core feature, I have added thorough tests
My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

greptile-apps · 2026-05-01T17:35:03Z

Greptile Summary

This PR adds 24 unit tests for _get_total_ram_gb(), _get_available_ram_gb(), and detect_hardware() in app/cli/local_llm/hardware.py. Tests cover Linux /proc/meminfo parsing, macOS sysctl calls, unknown-platform fallbacks, parse errors, missing keys, and full profile assembly — all with zero host-OS dependency via sys.platform patching.

Confidence Score: 5/5

Safe to merge — only a minor style nit on a test helper, no logic issues.

All findings are P2. The tests are logically correct, mock targets are accurate, fallback values and arithmetic match the implementation, and the iteration pattern used with mock_open is fully supported in Python 3.11+.

No files require special attention.

Important Files Changed

Filename	Overview
tests/cli/test_local_llm_hardware.py	Adds 24 unit tests across 8 test classes for _get_total_ram_gb, _get_available_ram_gb, and detect_hardware; all paths correctly mocked; minor missing return type on _detect helper

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[detect_hardware] --> B[_get_total_ram_gb]
    A --> C["_get_available_ram_gb(total)"]
    A --> D[platform.machine]
    A --> E["shutil.which('nvidia-smi')"]

    B --> B1{sys.platform?}
    B1 -->|darwin| B2["sysctl -n hw.memsize"]
    B1 -->|linux| B3["read /proc/meminfo MemTotal"]
    B1 -->|other or error| B4["fallback = 8.0 GB"]

    C --> C1{sys.platform?}
    C1 -->|darwin| C2["sysctl -n hw.usermem"]
    C1 -->|linux| C3["read /proc/meminfo MemAvailable"]
    C1 -->|other or error| C4["total * 0.5"]

    A --> F[HardwareProfile]
    F --> F1[total_ram_gb]
    F --> F2[available_ram_gb]
    F --> F3[arch]
    F --> F4[is_apple_silicon]
    F --> F5[has_nvidia_gpu]

_{Reviews (1): Last reviewed commit: "Test: Add direct tests for hardware dete..." | Re-trigger Greptile}

greptile-apps · 2026-05-01T17:35:07Z

+
+
+# ---------------------------------------------------------------------------
+# _get_available_ram_gb — unknown / Windows platform
+# ---------------------------------------------------------------------------
+
+
+class TestGetAvailableRamGbUnknownPlatform:
+    def test_returns_half_total_on_unrecognised_platform(self) -> None:


Missing return type annotation on _detect helper

The code style guide requires type hints on all function parameters and return types, but _detect has no return annotation. The return type is HardwareProfile.

Suggested change

# ---------------------------------------------------------------------------

# _get_available_ram_gb — unknown / Windows platform

# ---------------------------------------------------------------------------

class TestGetAvailableRamGbUnknownPlatform:

def test_returns_half_total_on_unrecognised_platform(self) -> None:

def _detect(

self,

*,

platform_str: str,

machine: str,

total_gb: float,

available_gb: float,

nvidia: bool,

) -> "HardwareProfile":

Context Used: Code style and conventions (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

+
+from __future__ import annotations
+
+import sys


muddlebee · 2026-05-02T06:12:14Z

@umeraamir09 CI is failing

Devesh36 · 2026-05-03T06:50:22Z

Hey @umeraamir09 could you please resolve the test which are failing . Thankss !!

VaibhavUpreti

awesome @umeraamir09 ! Welcome to the OpenSRE community

github-actions · 2026-05-03T17:39:50Z

🔥 Another one. @umeraamir09 said "here's a PR" and maintainers said "ship it". That's how it's done.

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Test: Add direct tests for hardware detection helpers

8d9ba4a

umeraamir09 changed the title ~~Added direct unit tests for app/cli/local_llm/hardware.py~~ test: added direct unit tests for app/cli/local_llm/hardware.py May 1, 2026

greptile-apps Bot reviewed May 1, 2026

View reviewed changes

github-advanced-security AI found potential problems May 1, 2026

View reviewed changes

Comment thread tests/cli/test_local_llm_hardware.py

from __future__ import annotations

import sys

khanbilal732 approved these changes May 2, 2026

View reviewed changes

fix: use assert_any_call to handle parallel PostHog mock pollution

93d41d2

VaibhavUpreti approved these changes May 3, 2026

View reviewed changes

VaibhavUpreti merged commit bd7dd1e into Tracer-Cloud:main May 3, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: added direct unit tests for app/cli/local_llm/hardware.py#1187

test: added direct unit tests for app/cli/local_llm/hardware.py#1187
VaibhavUpreti merged 2 commits intoTracer-Cloud:mainfrom
umeraamir09:issue/905-test-hardware-detection-coverage

umeraamir09 commented May 1, 2026

Uh oh!

greptile-apps Bot commented May 1, 2026

Uh oh!

greptile-apps Bot May 1, 2026

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Devesh36 commented May 3, 2026

Uh oh!

VaibhavUpreti left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

-# ---------------------------------------------------------------------------
-# _get_available_ram_gb — unknown / Windows platform
-# ---------------------------------------------------------------------------
-class TestGetAvailableRamGbUnknownPlatform:
-    def test_returns_half_total_on_unrecognised_platform(self) -> None:
+    def _detect(
+        self,
+        *,
+        platform_str: str,
+        machine: str,
+        total_gb: float,
+        available_gb: float,
+        nvidia: bool,
+    ) -> "HardwareProfile":

Conversation

umeraamir09 commented May 1, 2026

Describe the changes you have made in this PR -

Demo/Screenshot for feature changes and bug fixes -

Code Understanding and AI Usage

Checklist before requesting a review

Uh oh!

greptile-apps Bot commented May 1, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot May 1, 2026

Choose a reason for hiding this comment

Uh oh!

muddlebee commented May 2, 2026

Uh oh!

Devesh36 commented May 3, 2026

Uh oh!

VaibhavUpreti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants