Skip to content

docs: add 'Run one focused test' section to CONTRIBUTING.md#1177

Merged
muddlebee merged 2 commits intoTracer-Cloud:mainfrom
akshat1074:docs/run-focused-test-section
May 1, 2026
Merged

docs: add 'Run one focused test' section to CONTRIBUTING.md#1177
muddlebee merged 2 commits intoTracer-Cloud:mainfrom
akshat1074:docs/run-focused-test-section

Conversation

@akshat1074
Copy link
Copy Markdown
Contributor

Fixes #1128

Describe the changes you have made in this PR -

docs: add 'Run one focused test' section to CONTRIBUTING.md

Added a short Run one focused test section under Development Workflow with three copy-paste-ready pytest commands using real repo paths (tests/cli/, tests/tools/, tests/synthetic/)

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 1, 2026

Greptile Summary

This PR adds a "Run one focused test" subsection to the Development Workflow in CONTRIBUTING.md. The new section has two issues that need fixing before it is useful to contributors:

  • Broken Markdown formatting (P1): Every added line starts with a literal + character, copied verbatim from a diff view. The heading and fenced code blocks will not render correctly in any Markdown viewer.
  • Misleading commands (P2): The section promises single/focused test commands, but each example targets an entire directory (tests/cli/, tests/tools/, tests/synthetic/), running hundreds of tests rather than one.

Confidence Score: 3/5

Not safe to merge as-is — the documentation section will render as broken plain text due to literal + prefixes on every new line.

The P1 formatting bug means the added section is non-functional documentation: the heading won't render as a heading and the code fences won't render as code blocks in any standard Markdown viewer. The content inaccuracy (directory-wide commands vs. single-test focus) is a secondary P2 concern. Both should be corrected before merging.

CONTRIBUTING.md — all added lines need the leading + characters stripped and commands updated to target individual test files.

Important Files Changed

Filename Overview
CONTRIBUTING.md Adds a "Run one focused test" section, but all new lines start with a literal + character (copy-paste artifact from a diff view), breaking Markdown rendering; the commands also target whole directories rather than single tests as the descriptions claim.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer makes a change] --> B[Run focused test\npytest tests/cli/test_foo.py]
    B --> C{Tests pass?}
    C -- Yes --> D[Run full local checks\nmake lint + format-check\n+ typecheck + test-cov]
    C -- No --> E[Fix code / tests]
    E --> B
    D --> F{All four pass?}
    F -- Yes --> G[Open Pull Request]
    F -- No --> H[Fix issues]
    H --> D
Loading

Reviews (1): Last reviewed commit: "docs: add 'Run one focused test' section..." | Re-trigger Greptile

Comment thread CONTRIBUTING.md Outdated
Comment on lines +114 to +130
+### Run one focused test
+
+Run a single CLI test file:
+```
+pytest tests/cli/
+```
+
+Run one specific test in the tools suite:
+```
+pytest tests/tools/
+```
+
+Run a synthetic scenario (no live infra needed):
+```
+pytest tests/synthetic/
+```
+
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Literal + characters in file content

Every line in the new section starts with a literal + character (e.g. +### Run one focused test, +pytest tests/cli/). These appear to have been copied directly from a diff/patch view. As a result, the heading will not render as Markdown and the fenced code blocks will not display correctly.

Comment thread CONTRIBUTING.md Outdated
Comment on lines +114 to +129
+### Run one focused test
+
+Run a single CLI test file:
+```
+pytest tests/cli/
+```
+
+Run one specific test in the tools suite:
+```
+pytest tests/tools/
+```
+
+Run a synthetic scenario (no live infra needed):
+```
+pytest tests/synthetic/
+```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Commands run entire suites, not focused tests

The section is titled "Run one focused test" and the descriptions say "a single CLI test file" / "one specific test", but each command targets a whole directory and will run hundreds of tests. For actually isolating one test, a developer would need pytest tests/cli/test_main.py (single file), pytest tests/tools/test_foo.py::TestClass::test_method (single function), or pytest tests/cli/ -k "test_investigate" (keyword filter). Consider updating the commands or renaming the section to "Run a subset of tests."

Comment thread CONTRIBUTING.md Outdated
Comment on lines +113 to +114
All four must pass. **CI will block merging if any fail.**
+### Run one focused test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing blank line before new heading

There is no blank line between "All four must pass…" and the new ### Run one focused test heading. Some Markdown renderers require a blank line before a heading to parse it correctly.

@akshat1074 akshat1074 force-pushed the docs/run-focused-test-section branch from 723aa81 to 084ee5e Compare May 1, 2026 12:30
@muddlebee muddlebee merged commit 0011af4 into Tracer-Cloud:main May 1, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

🔥 Another one. @akshat1074 said "here's a PR" and maintainers said "ship it". That's how it's done.


👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a run one focused test file section to CONTRIBUTING.md

2 participants