feat(github): add 16 PR celebration message templates#1088
Conversation
- add 16 new unhinged/humorous message templates to the post-merge comment script - cover themes: rubber duck debugging, pizza theory, git history permanence, alien threat assessment, tea-speed merges, interview skit, poet arc, and more - fix broken f-string interpolation in scientists/baffled template - original 8 templates in main left untouched
muddlebee
changed the title
|
🏆 @muddlebee did not come to play. PR opened. Review survived. Merged clean. Retire the jersey. 🎽
👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome. |
Greptile SummaryThis PR adds 16 new meme-tier celebration message templates to the merged-PR comment script, expanding the random-pick pool from 8 to 24. All new entries are purely additive, follow the existing f-string pattern, and correctly interpolate Confidence Score: 5/5Safe to merge — all 16 templates are syntactically correct and the only findings are minor style inconsistencies. All P0/P1 criteria are clear: every No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GitHub Actions: PR Merged] --> B[merged_pr_celebration_message.py]
B --> C{Read env vars}
C --> D[CONTRIBUTOR_LOGIN → contributor]
C --> E[DISCORD_INVITE_URL → discord]
D & E --> F[random.choice from templates\n8 original + 16 new = 24 total]
F --> G[random.choice from gif_blocks\n10 GIFs]
G --> H[Assemble: template + gif + footer]
H --> I[Write to comment.md]
I --> J[Action posts comment.md\non merged PR]
Reviews (1): Last reviewed commit: "refactor(github): trim celebration templ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| f"🤖 **CI passed. Linter didn't scream. Reviewer typed LGTM.** " | ||
| f"@{contributor}, every machine in this pipeline just slow-clapped. 🖥️✨" |
There was a problem hiding this comment.
f prefix on interpolation-free strings
Several first segments in the new multi-line string pairs carry an f prefix even though they contain no {...} placeholders — the rest of the file consistently omits f on those parts. Five occurrences in the new additions: lines 58, 66, 86, 94, and 102.
| f"🤖 **CI passed. Linter didn't scream. Reviewer typed LGTM.** " | |
| f"@{contributor}, every machine in this pipeline just slow-clapped. 🖥️✨" | |
| "🤖 **CI passed. Linter didn't scream. Reviewer typed LGTM.** " | |
| f"@{contributor}, every machine in this pipeline just slow-clapped. 🖥️✨" |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| f"💼 **Interviewer:** describe a time you shipped something impactful.\n\n" | ||
| f"**@{contributor}:** *points at this PR*\n\n" | ||
| "**Interviewer:** you're hired. 🤝" | ||
| ) |
There was a problem hiding this comment.
All other entries in templates end with ,. The final new entry drops it, diverging from the consistent style of the list and making future append diffs noisier.
| ) | |
| ), | |
| ] |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Fixes #
Describe the changes you have made in this PR -
Adds 16 new unhinged/meme-tier message templates to
.github/scripts/merged_pr_celebration_message.py, the script that posts a celebration comment whenever a PR is merged.The original 8 templates already in
mainare untouched. The new ones are appended after a# new additionscomment.New templates cover:
Also fixes a broken f-string in the scientists/baffled template where
@{contributor}was in a plain string instead of an f-string.Code Understanding and AI Usage
Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?
If you used AI assistance:
Explain your implementation approach:
The script picks a random template and a random GIF from their respective lists. Adding more templates reduces repeat frequency — pool grows from 8 to 24. All new entries follow the same f-string pattern as the originals. Script was smoke-tested locally with
DISCORD_INVITE_URLandCONTRIBUTOR_LOGINenv vars to verify all interpolations render correctly.Checklist before requesting a review
Note: Please check Allow edits from maintainers if you would like us to assist in the PR.