Skip to content

chore(github): trim celebration GIFs and add three new merge GIFs#1075

Merged
muddlebee merged 2 commits intomainfrom
chore/remove-celebration-gifs
Apr 29, 2026
Merged

chore(github): trim celebration GIFs and add three new merge GIFs#1075
muddlebee merged 2 commits intomainfrom
chore/remove-celebration-gifs

Conversation

@muddlebee
Copy link
Copy Markdown
Collaborator

@muddlebee muddlebee commented Apr 29, 2026 •
edited
Loading

Fixes #

Community: Contributors hang out on Discord — OpenSRE (#contribute) for questions, reviews, and roadmap chatter.

Describe the changes you have made in this PR -

Removes four repo-hosted GIFs (winner.gif, office-yes.gif, office-dance.gif, office-win.gif) and drops their references from .github/scripts/merged_pr_celebration_message.py.

Adds three new repo-hosted GIFs as merge-celebrate-{1,2,3}.gif (downloaded from Giphy search URLs below) and registers them in gif_blocks.

After merge the bot will randomly pick among: party.gif, celebrate.gif, ship.gif, shipped.gif, fireworks.gif, woohoo.gif, office-celebrate.gif, merge-celebrate-1.gif, merge-celebrate-2.gif, merge-celebrate-3.gif.

Giphy sources (commit stores binaries under .github/assets/celebrations/; runtime uses raw.githubusercontent.com):

Demo/Screenshot for feature changes and bug fixes -

Preview on this branch:

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

  • Yes, I used AI assistance (continue below)

If you used AI assistance:

  • I have reviewed every single line of the AI-generated code
  • I can explain the purpose and logic of each function/component I added
  • I have tested edge cases and understand how the code handles them
  • I have modified the AI output to follow this project's coding standards and conventions

Explain your implementation approach:

Removed assets with git rm; appended three new GIF binaries and matching gif_blocks entries.

Checklist before requesting a review

  • I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • I can explain the purpose of every function, class, and logic block I added
  • I understand why my changes work and have tested them thoroughly
  • I have considered potential edge cases and how my code handles them
  • My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

@muddlebee
chore(github): drop winner and three Office GIFs from merge celebration
8e2fd98 
Remove office-yes, office-dance, office-win, winner assets and references.
Keep office-celebrate.gif plus existing party/celebrate/ship/shipped/fireworks/woohoo.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR removes four GIF binary assets (winner.gif, office-yes.gif, office-dance.gif, office-win.gif) from .github/assets/celebrations/ and drops their corresponding entries from the gif_blocks list in the merge-bot celebration script. The asset deletions and script entries are in perfect sync — all 7 remaining gif_blocks entries have matching files on disk.

Confidence Score: 5/5

Safe to merge — purely additive cleanup with no logic changes and no broken references.

All removed script entries correspond exactly to the deleted assets, and all remaining script references have verified files on disk. No logic, no tests, no configuration is affected.

No files require special attention.

Important Files Changed

Filename Overview
.github/scripts/merged_pr_celebration_message.py Removed 4 entries from gif_blocks matching the deleted GIF assets; remaining 7 entries all have corresponding files on disk.
.github/assets/celebrations/office-dance.gif Binary GIF asset deleted; corresponding script entry also removed.
.github/assets/celebrations/office-win.gif Binary GIF asset deleted; corresponding script entry also removed.
.github/assets/celebrations/office-yes.gif Binary GIF asset deleted; corresponding script entry also removed.
.github/assets/celebrations/winner.gif Binary GIF asset deleted; corresponding script entry also removed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[GitHub Actions: PR merged] --> B[merged_pr_celebration_message.py]
    B --> C[random.choice templates]
    B --> D[random.choice gif_blocks]
    D --> E[party.gif]
    D --> F[celebrate.gif]
    D --> G[ship.gif]
    D --> H[shipped.gif]
    D --> I[fireworks.gif]
    D --> J[woohoo.gif]
    D --> K[office-celebrate.gif]
    C --> L[Compose body]
    D --> L
    L --> M[Write comment.md]
    M --> N[Post PR comment]
Loading

Reviews (1): Last reviewed commit: "chore(github): drop winner and three Off..." | Re-trigger Greptile

@muddlebee
feat(github): add three celebration GIFs for merge bot
a69a4a2 
Adds merge-celebrate-{1,2,3}.gif (repo-hosted) and wires into gif_blocks.
@muddlebee muddlebee changed the title chore(github): remove four celebration GIFs from merge bot chore(github): trim celebration GIFs and add three new merge GIFs Apr 29, 2026
@muddlebee muddlebee merged commit 3ee1c62 into main Apr 29, 2026
3 checks passed
@muddlebee muddlebee deleted the chore/remove-celebration-gifs branch April 29, 2026 12:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

🎊 Achievement unlocked: PR Merged. @muddlebee passed code review, survived CI, and shipped. Respect. 🤝

👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@muddlebee