Skip to content

fix(github): add woohoo.gif and polish post-merge celebration messages#1049

Merged
muddlebee merged 1 commit intomainfrom
fix/pr-celebration-final
Apr 28, 2026
Merged

fix(github): add woohoo.gif and polish post-merge celebration messages#1049
muddlebee merged 1 commit intomainfrom
fix/pr-celebration-final

Conversation

@muddlebee
Copy link
Copy Markdown
Collaborator

Fixes #

Community: Contributors hang out on Discord — OpenSRE (#contribute) for questions, reviews, and roadmap chatter.

Describe the changes you have made in this PR -

Follow-up to #1045. Adds woohoo.gif and includes all 7 repo-hosted celebration GIFs + polished messages.

File Size
party.gif 4.6 MB 🎉
celebrate.gif 1.3 MB 🥳
fireworks.gif 1.2 MB 🎆
woohoo.gif 1.1 MB 🙌
ship.gif 375 KB 🚢
shipped.gif 439 KB
success.gif 482 KB 💪

Demo/Screenshot for feature changes and bug fixes -


Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

  • Yes, I used AI assistance (continue below)

If you used AI assistance:

  • I have reviewed every single line of the AI-generated code
  • I can explain the purpose and logic of each function/component I added
  • I have tested edge cases and understand how the code handles them
  • I have modified the AI output to follow this project's coding standards and conventions

Explain your implementation approach:

Python script picks random template + random GIF path, writes comment.md. Workflow posts it via gh pr comment. All GIFs committed to repo so GitHub CDN serves them reliably.


Checklist before requesting a review

  • I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • I can explain the purpose of every function, class, and logic block I added
  • I understand why my changes work and have tested them thoroughly
  • I have considered potential edge cases and how my code handles them
  • My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

Made with Cursor

- Host 7 GIFs in .github/assets/celebrations/ via GitHub CDN
  (party, celebrate, ship, shipped, success, fireworks, woohoo)
- Drop all Giphy URLs — GitHub camo proxy blocks them inconsistently
- 9 fun varied message templates, cleaner Discord footer

Made-with: Cursor
@muddlebee muddlebee merged commit 754ee2c into main Apr 28, 2026
3 checks passed
@muddlebee muddlebee deleted the fix/pr-celebration-final branch April 28, 2026 16:02
@github-actions
Copy link
Copy Markdown
Contributor

🎉 MERGED! @muddlebee just shipped something. The diff gods are pleased. 🙌


👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR completes the celebration GIF set by adding woohoo.gif (1.1 MB) and wiring it into merged_pr_celebration_message.py, so all 7 repo-hosted GIFs are now included in the random selection pool alongside the 2 empty slots (~22% emoji-only rate unchanged).

Confidence Score: 5/5

Safe to merge — minimal, low-risk change that adds one GIF asset and a single list entry

The change is a one-line addition to a list and a new binary asset. No logic is altered, the probability distribution comment (~22% emoji-only) still holds (2/9 ≈ 22%), and the GIF URL pattern matches the existing entries exactly. No P0 or P1 issues found.

No files require special attention

Important Files Changed

Filename Overview
.github/scripts/merged_pr_celebration_message.py Adds woohoo.gif to the gif_blocks list; now all 7 repo-hosted celebration GIFs are included alongside the 2 empty slots (~22% emoji-only rate preserved)
.github/assets/celebrations/woohoo.gif New 1.1 MB binary GIF asset committed to the repo for GitHub CDN serving

Sequence Diagram

sequenceDiagram
    participant A as GitHub Actions (post-merge)
    participant S as merged_pr_celebration_message.py
    participant F as comment.md
    participant G as gh pr comment

    A->>S: run script (env: CONTRIBUTOR_LOGIN, DISCORD_INVITE_URL)
    S->>S: random.choice(templates) → head message
    S->>S: random.choice(gif_blocks) → "" | GIF markdown
    Note over S: gif_blocks now includes woohoo.gif (9 items total)
    S->>F: write head + footer → comment.md
    A->>G: gh pr comment --body-file comment.md
    G-->>A: comment posted on merged PR
Loading

Reviews (1): Last reviewed commit: "fix(github): add celebration GIFs and po..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant