fix(gifs): host celebration GIFs in repo to fix GitHub proxy rendering#1045
fix(gifs): host celebration GIFs in repo to fix GitHub proxy rendering#1045
Conversation
- Add 4 GIFs under .github/assets/celebrations/ served via GitHub CDN - Drop all Giphy URLs — GitHub camo proxy inconsistently blocks them - Polish message templates (9 fun varied lines, removed weak ones) - Clearer Discord footer copy Made-with: Cursor
muddlebee
changed the title
Greptile SummaryThis PR fixes unreliable GIF rendering in bot merge-celebration comments by replacing Giphy hotlinks with four GIF assets committed directly to the repo and served via Confidence Score: 5/5Safe to merge — only a minor GIF duplication and stale comment to clean up, no functional breakage. The single finding is a P2 cosmetic/distribution issue:
Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Script as merged_pr_celebration_message.py
participant CDN as raw.githubusercontent.com
participant PR as PR Comment
GHA->>Script: Run after merge (CONTRIBUTOR_LOGIN, DISCORD_INVITE_URL)
Script->>Script: random.choice(templates) + random.choice(gif_blocks)
Script->>Script: Write body to comment.md
GHA->>PR: gh pr comment --body-file comment.md
PR->>CDN: Fetch GIF from /main/.github/assets/celebrations/*.gif
CDN-->>PR: Serve GIF (always reliable, no proxy)
Reviews (1): Last reviewed commit: "fix(github): host celebration GIFs in re..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| f"\n\n", | ||
| f"\n\n", | ||
| f"\n\n", | ||
| f"\n\n", |
There was a problem hiding this comment.
party.gif entry skews distribution
party.gif appears twice in gif_blocks (lines 52 and 56), giving it a 2-in-7 (~28.6%) chance versus 1-in-7 (~14.3%) for the other three GIFs. This also makes the inline comment inaccurate — with 7 items the emoji-only probability is ~28.6%, not ~22% (which would be 2-in-9, matching the old list). Likely unintentional given the PR description says all 4 committed GIFs were meant to be distinct options.
| f"\n\n", | |
| f"\n\n", | |
| ] |
- hooray.gif 85KB — arms-up cheer - success.gif 482KB — success reaction - shipped.gif 439KB — ship it - cheers.gif 980KB — celebration cheer - fireworks.gif 1.2MB — fireworks burst - confetti.gif 1.5MB — confetti drop Made-with: Cursor
7 GIFs total: party, celebrate, ship, merge, shipped, success, fireworks Made-with: Cursor
Made-with: Cursor
|
note to maintainers -> moved gif to github CDN since giphy doesn't work well.. |
|
⚡ LGTM → Merged. @muddlebee, your work is in. Every commit counts — thank you for this one. 👋 Join us on Discord - OpenSRE : hang out, contribute, or hunt for features and issues. Everyone's welcome. |
1 participant
Fixes #
Community: Contributors hang out on Discord — OpenSRE (
#contribute) for questions, reviews, and roadmap chatter.Describe the changes you have made in this PR -
Follow-up to #1039. GitHub's
camoimage proxy inconsistently blocks Giphy hotlinks, causing GIFs to silently fail in bot comments..github/assets/celebrations/— served directly byraw.githubusercontent.com(GitHub's own CDN, always reliable)xT9IgG50Lg7russbCY==zGnnFpOB6s5oNa5VlZ, identical bytes)Demo/Screenshot for feature changes and bug fixes -
GIF assets live on this branch:
Code Understanding and AI Usage
Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?
If you used AI assistance:
Explain your implementation approach:
Python script picks a random template + random GIF path and writes
comment.md. The workflow posts it viagh pr comment. GIFs are committed to the repo so GitHub's own CDN serves them reliably.Checklist before requesting a review
Note: Please check Allow edits from maintainers if you would like us to assist in the PR.
Made with Cursor