Unused MagicMock import

MagicMock is imported but never referenced in this file — only patch is used. This will be flagged as F401 by ruff check, contradicting the PR's stated validation step.

Missing is_available negative case for absent repo_slug

_list_bitbucket_commits_available requires both the four credentials and a repo_slug (or repo) key. The parametrized matrix has no case where all four credentials are fully supplied but repo_slug is omitted — so the per-field credential tests don't prove that the repo_slug guard works independently of the credential guards. Adding a case like {"bitbucket": {"connection_verified": True, "workspace": "acme", "username": "bb-user", "app_password": "bb-pass"}} → False would complete the coverage.

Missing is_available negative cases for credential-present-but-field-absent combinations

_get_bitbucket_file_contents_available requires credentials and both repo_slug and path. The current matrix only has single-field cases (workspace alone, repo_slug alone, path alone), so there's no case proving the function returns False when credentials are fully satisfied but path is absent, or credentials + path are present but repo_slug is absent. Adding those two cases would fully verify the compound guard.

The missing-credentials test relies on the real environment having no BITBUCKET_* variables. If BITBUCKET_WORKSPACE (and/or credentials) are set locally/CI, _resolve_config() may return a non-None config, causing this test to either make a real network call or return a different shape (e.g., error: "Not configured."). Patch app.tools.BitbucketSearchCodeTool.bitbucket_config_from_env to return None in this test to keep it deterministic.

This missing-credentials test can become flaky if BITBUCKET_* env vars are present, because _resolve_config() may load env config and the tool may call the real Bitbucket integration. Patch app.tools.BitbucketSearchCodeTool.bitbucket_config_from_env to return None here so the test always exercises the unavailable path without side effects.

This missing-credentials test assumes there is no Bitbucket env configuration. If BITBUCKET_WORKSPACE/credentials are set, _resolve_config() can return a config and the tool may call the real Bitbucket API (or return a different error payload). Patch app.tools.BitbucketSearchCodeTool.bitbucket_config_from_env to return None in this test to make it deterministic and side-effect free.

This greptile thread is still open. The parametrize list is missing the case where all four credentials are present but repo_slug is absent.

_list_bitbucket_commits_available checks _bb_available(sources) and bb.get('repo_slug', bb.get('repo')) — so a source dict with verified credentials but no repo_slug key should return False. That path has no test coverage.

Add one more parametrize case:

(
    {
        "bitbucket": {
            "connection_verified": True,
            "workspace": "acme",
            "username": "bb-user",
            "app_password": "bb-pass",
            # repo_slug intentionally absent
        }
    },
    False,
),

This catches regressions where someone accidentally removes the repo_slug guard from is_available.

Same issue as the commits tool. _get_bitbucket_file_contents_available requires credentials AND both repo_slug AND path. The test matrix has the case where credentials are present but path is absent (sources2), but it's missing the symmetric case: credentials present, repo_slug present, path absent.

Add:

(
    {
        "bitbucket": {
            "connection_verified": True,
            "workspace": "acme",
            "username": "bb-user",
            "app_password": "bb-pass",
            "repo_slug": "backend-service",
            # path intentionally absent
        }
    },
    False,
),

This ensures that if the bb.get('path') guard is ever accidentally removed from is_available, a test breaks.