fix(rbac): give org members scope to run agents#2618
Merged
daryllimyt merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
jordan-umusu
temporarily deployed
to
internal-registry-ci
GitHub Actions
Inactive
jordan-umusu
temporarily deployed
to
internal-registry-ci
GitHub Actions
Inactive
daryllimyt
approved these changes
May 5, 2026
jordan-umusu
added
the
priority:critical
|
✅ No security or compliance issues detected. Reviewed everything up to 87add39. Security OverviewDetected Code Changes
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 2/5
- High-risk authorization change in
tracecat/authz/scopes.py: grantingorg:secret:readto all organization members appears to exceed the intended scope (agent execution) and can expose org secrets to broader roles. - The issue is both high severity and high confidence (8/10 each), which suggests a concrete security regression rather than a minor policy tweak.
- Pay close attention to
tracecat/authz/scopes.py- permission scope expansion may over-grant secret read access and should be narrowed before merge.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tracecat/authz/scopes.py">
<violation number="1" location="tracecat/authz/scopes.py:324">
P1: Adding `org:secret:read` to organization members over-grants access: members can now call org secret read endpoints, which is broader than the stated goal of enabling agent execution.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
|
Blacksmith runners detected OOM events on the following jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Allow organization members to run agents by adding the missing
org:secret:readscope to theorganization-memberpreset. This unblocks agent execution that needs org secrets.org:secret:readtoorganization-memberinPRESET_ROLE_SCOPES.agent:read,agent:execute, andorg:secret:read.Written for commit 87add39. Summary will update on new commits.