fix: Sanitize and normalize skill name input inline#2606
Merged
daryllimyt merged 2 commits intomainfrom May 4, 2026
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 745409b. Security OverviewDetected Code Changes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 400ba813c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jordan-umusu
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
slugifyusage with an inline normalization to ensure skill names are consistently formatted client-side before validation.validateSkillNamecheck receives normalized input.Description
slugifyimport and updated theonChangefor the nameInputto perform inline normalization.validateSkillNameand error UI are unchanged and still applied after normalization.Testing
pnpm build) to verify there are no TypeScript or bundling errors, and the build succeeded.pnpm test) and the test suite passed.Codex Task
Summary by cubic
Normalize skill name input inline with Unicode support to enforce kebab-case before validation. Strips diacritics so accented names like “Café Tools” become “cafe-tools”, ensuring
validateSkillNamealways receives normalized input.slugifywith inline normalization in the name input’sonChange._→-, remove invalid chars, collapse spaces/hyphens to-, trim edges.validateSkillNameand error UI remain unchanged.Written for commit 745409b. Summary will update on new commits.