Skip to content

feat(ui): expose action output masking in UI#2588

Merged
daryllimyt merged 1 commit intomainfrom
codex/add-mask-output-control-flow
Apr 30, 2026
Merged

feat(ui): expose action output masking in UI#2588
daryllimyt merged 1 commit intomainfrom
codex/add-mask-output-control-flow

Conversation

@daryllimyt
Copy link
Copy Markdown
Contributor

Summary

  • Add mask_output to action control-flow schema and generated frontend client types.
  • Surface a Mask output switch in the action panel control-flow settings.
  • Preserve mask_output through workflow import/export action conversion paths.

Why

The original masking behavior was merged, but these follow-up UI/control-flow propagation changes were left as local worktree changes on the old branch. This PR applies that missing diff on top of current main.

Validation

  • uv run pytest tests/unit/test_view.py::test_build_action_statements_simple_sequence tests/unit/test_workflow_import_service.py
  • uv run ruff check tracecat/dsl/common.py tracecat/workflow/actions/schemas.py tracecat/workflow/management/management.py tests/unit/test_view.py tests/unit/test_workflow_import_service.py
  • uv run ruff format --check tracecat/dsl/common.py tracecat/workflow/actions/schemas.py tracecat/workflow/management/management.py tests/unit/test_view.py tests/unit/test_workflow_import_service.py
  • uv run basedpyright --warnings --threads 4 tracecat/dsl/common.py tracecat/workflow/actions/schemas.py tracecat/workflow/management/management.py tests/unit/test_view.py tests/unit/test_workflow_import_service.py
  • pnpm -C frontend exec biome check src/components/builder/panel/action-panel.tsx src/client/schemas.gen.ts src/client/types.gen.ts
  • pnpm -C frontend run typecheck
  • commit hooks passed

@daryllimyt daryllimyt temporarily deployed to internal-registry-ci April 30, 2026 20:12 — with GitHub Actions Inactive
@daryllimyt daryllimyt requested a review from jordan-umusu April 30, 2026 20:12
@daryllimyt daryllimyt temporarily deployed to internal-registry-ci April 30, 2026 20:12 — with GitHub Actions Inactive
@daryllimyt daryllimyt marked this pull request as ready for review April 30, 2026 20:13
@daryllimyt daryllimyt changed the title [codex] expose action output masking to UI feat(ui): expose action output masking in UI Apr 30, 2026
@zeropath-ai
Copy link
Copy Markdown

zeropath-ai Bot commented Apr 30, 2026

No security or compliance issues detected. Reviewed everything up to 7bdabbf.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► frontend/src/client/schemas.gen.ts
    Add mask_output schema definition
► frontend/src/client/types.gen.ts
    Add mask_output type definition
► frontend/src/components/builder/panel/action-panel.tsx
    Implement mask_output field in UI and form
► tests/unit/test_view.py
    Add test case for mask_output in action statements
► tests/unit/test_workflow_import_service.py
    Add test for mask_output during DSL import
► tracecat/dsl/common.py
    Pass mask_output to ActionStatement
► tracecat/workflow/actions/schemas.py
    Add mask_output to ActionControlFlow schema
► tracecat/workflow/management/management.py
    Pass mask_output when creating Action objects

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@daryllimyt daryllimyt merged commit 1d02340 into main Apr 30, 2026
19 checks passed
@daryllimyt daryllimyt deleted the codex/add-mask-output-control-flow branch April 30, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants