feat(ee): Gate service accounts behind entitlement#2582
Merged
daryllimyt merged 3 commits intomainfrom Apr 30, 2026
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 1b6c511. Security OverviewDetected Code Changes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1614bb5020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
service_accountsentitlement is not enabled.Description
useEntitlements, renderEntitlementRequiredEmptyStatewhen service accounts are disabled, and passenabledflags to service account hooks (useOrganizationServiceAccounts,useWorkspaceServiceAccounts,useOrganizationServiceAccountScopes,useWorkspaceServiceAccountScopes) to avoid unnecessary queries.AppSidebarandOrganizationSidebarunlessservice_accountsentitlement is present and entitlements have finished loading.SERVICE_ACCOUNTStoEntitlementenum and includedservice_accountsin entitlement schemas and defaults (tiers/schemas.py,tiers/enums.py,tiers/defaults.py,tiers/types.py).@requires_entitlement(Entitlement.SERVICE_ACCOUNTS)on service methods, and by blocking API key auth if the organization is not entitled (auth/credentials.py,service_accounts/router.py,service_accounts/service.py).Testing
Codex Task
Summary by cubic
Gate service accounts behind the org
service_accountsentitlement across UI and API. When not entitled, the UI hides service accounts and API key auth for service accounts is rejected to meet the API key access gating requirement.New Features
Entitlement.SERVICE_ACCOUNTSand wiredservice_accountsthrough tier schemas, types, defaults, and resolver.Dependsand on service methods via@requires_entitlement(Entitlement.SERVICE_ACCOUNTS).service_accounts.EntitlementRequiredEmptyStateon settings pages; service account hooks accept anenabledflag to skip queries when not entitled.Migration
service_accountsfor tiers/orgs that should use service accounts (defaults remain false, including OSS).Written for commit 1614bb5. Summary will update on new commits. Review in cubic