fix: Throttle massive scatter gather regression test#2555
Merged
daryllimyt merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to b815acb. Security OverviewDetected Code Changes
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
daryllimyt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test-local scheduler concurrency cap for
test_scatter_gather_massive_payload_50x2mb_e2e.Why
The massive scatter/gather regression test drives a ~100MB logical payload through 50 branches. Without a local cap, the test can pressure Temporal and object storage enough to produce partial gather results under load.
Impact
Only this regression test is throttled. Production defaults and the other large collection regression tests are unchanged.
Validation
uv run ruff check tests/temporal/test_large_collection_regressions.pyuv run ruff format --check tests/temporal/test_large_collection_regressions.pyuv run basedpyright tests/temporal/test_large_collection_regressions.pyTRACECAT__SERVICE_KEY=test-service-key uv run pytest tests/temporal/test_large_collection_regressions.py::test_scatter_gather_massive_payload_50x2mb_e2e -qSummary by cubic
Caps the DSL scheduler concurrency to 8 within
test_scatter_gather_massive_payload_50x2mb_e2eto stabilize the 50×2MB scatter/gather run under load. This is test-only; production defaults and other large-collection tests are unchanged.TRACECAT__DSL_SCHEDULER_MAX_PENDING_TASKSto8via env andconfigmonkeypatch in this test to avoid load-induced partial gather results.Written for commit b815acb. Summary will update on new commits.