fix: remote custom registry test#2547
Merged
daryllimyt merged 7 commits intomainfrom Apr 21, 2026
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to dfe91a6. Security OverviewDetected Code Changes
|
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/conftest.py">
<violation number="1" location="tests/conftest.py:973">
P1: Do not promote the fake seeded version when no builtin selection exists; that can leave `s3://test/test.tar.gz` mounted as current and workflows will still fail to fetch the tarball.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 437a5bab91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3://test/test.tar.gz).registry_version_with_manifest, so temporal/integration tests do not clobber the API-synced builtin tarball with the fake fixture version.Root Cause
Commit
5d1d745c1made resolved workflow locks always includetracecat_registryas a runtime dependency. The remote custom registry test synced only the custom repo, so executor setup could try to download the builtin fixture placeholder tarball and fail with a 404.The additional CI failures came from tests assuming platform registry setup was isolated/idempotent. Platform registry rows are global by origin, so parallel setup could collide on
tracecat_registry, and the shared manifest fixture could overwrite a live platform registry current version withtest-versionand the fake tarball.Validation
uv run pytest tests/unit/test_registry_lock_resolution.py -n 4uv run pytest --collect-only -q tests/temporal/test_large_collection_regressions.py tests/integration/test_install_and_run_custom_remote_registry_flow.pyuv run ruff check tests/conftest.py tests/unit/test_registry_lock_resolution.py tests/integration/test_install_and_run_custom_remote_registry_flow.pyuv run ruff format --check tests/conftest.py tests/unit/test_registry_lock_resolution.py tests/integration/test_install_and_run_custom_remote_registry_flow.pyuv run basedpyright tests/conftest.py tests/unit/test_registry_lock_resolution.py tests/integration/test_install_and_run_custom_remote_registry_flow.pyCI is green for Ruff, Pyright, unit, registry, temporal, integration, custom registry install, CodeQL, Semgrep, and Terraform Cloud.
Summary by cubic
Fixes the remote custom registry integration test by syncing the builtin platform registry and ensuring a real tarball is selected, so
tracecat_registryresolves to a downloadable tarball and executor setup avoids 404s. Also makes registry setup idempotent, repairs missing current selections at startup, and applies a safe fixture fallback in shared DBs.DEFAULT_REGISTRY_ORIGIN) before the workflow; creates it if missing, forces sync when needed, and promotes a version with a real tarball when the placeholder is current.BuiltinRegistryHasNoSelectionErrorwhen the builtin has no selected version, so tests and workflows retry while sync is pending.Written for commit dfe91a6. Summary will update on new commits.